Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wifi: Scan extensions #12008

Merged
merged 12 commits into from
Aug 24, 2023
Merged

wifi: Scan extensions #12008

merged 12 commits into from
Aug 24, 2023

Conversation

sachinthegreen
Copy link
Contributor

Add support for Wi-Fi scan extensions.

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. manifest labels Aug 10, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 10, 2023 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@78106c7 nrfconnect/sdk-zephyr@582837b (main) nrfconnect/sdk-zephyr@78106c74..582837b2

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 10, 2023 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
desktop52_verification X
test-fw-nrfconnect-ble X
test-fw-nrfconnect-ble_samples X
test-fw-nrfconnect-chip X
test-fw-nrfconnect-fem X
test-fw-nrfconnect-nfc X
test-fw-nrfconnect-nrf-iot_cloud X
test-fw-nrfconnect-nrf-iot_mosh X
test-fw-nrfconnect-nrf-iot_positioning X
test-fw-nrfconnect-nrf-iot_samples X
test-fw-nrfconnect-nrf-iot_thingy91 X
test-fw-nrfconnect-nrf_crypto X
test-fw-nrfconnect-rpc X
test-fw-nrfconnect-rs X
test-fw-nrfconnect-tfm X
test-fw-nrfconnect-thread X
test-sdk-find-my X
test-sdk-wifi X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

krish2718
krish2718 requested changes Aug 10, 2023
View reviewed changes
samples/wifi/shell/prj.conf Outdated Show resolved Hide resolved
drivers/wifi/nrf700x/zephyr/src/zephyr_wifi_mgmt.c Outdated Show resolved Hide resolved
drivers/wifi/nrf700x/zephyr/src/zephyr_wifi_mgmt.c Outdated Show resolved Hide resolved
drivers/wifi/nrf700x/zephyr/src/zephyr_wifi_mgmt.c Outdated Show resolved Hide resolved
drivers/wifi/nrf700x/zephyr/src/zephyr_wifi_mgmt.c Outdated Show resolved Hide resolved
@sachinthegreen sachinthegreen force-pushed the nrf700x-scan-ext branch 4 times, most recently from 12205c1 to 69a31ab Compare August 11, 2023 14:23
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@sachinthegreen sachinthegreen force-pushed the nrf700x-scan-ext branch 2 times, most recently from 03e69a5 to 288a44b Compare August 14, 2023 12:18
@sachinthegreen sachinthegreen force-pushed the nrf700x-scan-ext branch 4 times, most recently from d9e8c93 to c3c037d Compare August 23, 2023 07:05
@doublemis1
Copy link
Contributor

matter/chip plan failed at connecting to wifi network

D: 13532 [DL]Connecting to WiFi network: router-node-test-119
E: wifi_nrf_disp_scan_zep: Unsupported band

E: 13542 [DL]Scan request failed -16
D: 16020 [DL]Sending indication for CHIPoBLE TX characteristic (ConnId 00, len 3)
D: 16114 [DL]Indication for CHIPoBLE TX characteristic done (ConnId 0x00, result 0x00)
D: 18589 [DL]Write request received for CHIPoBLE RX characteristic (ConnId 0x00)
D: 21096 [DL]Sending indication for CHIPoBLE TX characteristic (ConnId 00, len 3)
D: 21154 [DL]Indication for CHIPoBLE TX characteristic done (ConnId 0x00, result 0x00)
E: wifi_nrf_disp_scan_zep: Unsupported band

E: 21550 [DL]Scan request failed -16
E: 21553 [DL]WiFi driver does not respond, resetting the device...

@D-Triveni D-Triveni mentioned this pull request Aug 23, 2023
Closed
rlubos
rlubos reviewed Aug 23, 2023
View reviewed changes
west.yml Outdated Show resolved Hide resolved
sachinthegreen and others added 12 commits August 24, 2023 14:01
@sachinthegreen
manifest: sdk-zephyr: Pull in Wi-Fi scan extension support
18a17df 
Pull in Zephyr changes for Wi-Fi scan extensions feature.

Signed-off-by: Sachin D Kulkarni <sachin.kulkarni@nordicsemi.no>
@srinivas1201 @sachinthegreen
drivers: wifi: Update RPU patch to rev#4c28feaf389
d799d6b 
PHY:
[SHEL-1870]: Coexistence manager to decline all the priority window
requests received from SR device.
Removed BT request call. Expect LMAC to take care.
LMAC:
[SHEL-1870]: Wlan BT request call added before calling channel switch
and PHY open calls.
UMAC:
[SHEL-1661]: Modifying scan command in accordance with new scan API
extensions.
Driver:
[SHEL-1782]: Host changes according to new scan command.

Signed-off-by: srinivasa raju chintalapati <srinivasaraju.chintalapati@nordicsemi.no>
@sachinthegreen
drivers: wifi: Add support for scanning specific bands
7c8d6cf 
Add support for scanning supported individual Wi-Fi frequency bands or
combinations thereof.

Signed-off-by: Sachin D Kulkarni <sachin.kulkarni@nordicsemi.no>
@sachinthegreen
drivers: wifi: Add scan extension for active channel dwell times
67056ff 
Add scan extension to control time spent on active scan channels.

Signed-off-by: Sachin D Kulkarni <sachin.kulkarni@nordicsemi.no>
@sachinthegreen
drivers: wifi: Add scan extension for passive channel dwell times
45596ab 
Add scan extension to control scanning time spent on channels where
passive scanning is used.

Signed-off-by: Sachin D Kulkarni <sachin.kulkarni@nordicsemi.no>
@sachinthegreen
wifi: Move and rename the NRF700X_SCAN_LIMIT Kconfig parameter
8321c86 
The NRF700x_SCAN_LIMIT Kconfig parameter is now renamed as
WIFI_MGMT_SCAN_MAX_BSS_CNT and moved to the Wi-fi sub-system Kconfig.

Signed-off-by: Sachin D Kulkarni <sachin.kulkarni@nordicsemi.no>
@sachinthegreen
drivers: wifi: Override the WIFI_MGMT_SCAN_SSID_FILT_MAX param
9a2adb8 
Override the Wi-Fi sub-system Kconfig parameter
WIFI_MGMT_SCAN_SSID_FILT_MAX with our maximum supported value i.e. 2.

Signed-off-by: Sachin D Kulkarni <sachin.kulkarni@nordicsemi.no>
@sachinthegreen
drivers: wifi: Add scan extension for filtering SSIDs
0038ca4 
Add scan extension to scan only for specific SSIDs.

Signed-off-by: Sachin D Kulkarni <sachin.kulkarni@nordicsemi.no>
@sachinthegreen
drivers: wifi: Add scan extension for specifying channels
20b7fc4 
Add scan extension to scan only on specific channels. Only 20 MHz
channels are supported for now.

Signed-off-by: Sachin D Kulkarni <sachin.kulkarni@nordicsemi.no>
@sachinthegreen
doc: Update relevant docs with scan extensions information
a9762a3 
- Update Wi-Fi shell readme with details about scan extensions.
- Update changelog with a note regarding addition of scan extensions.

Signed-off-by: Sachin D Kulkarni <sachin.kulkarni@nordicsemi.no>
@sachinthegreen
drivers: wifi: Add scan extension for forcing passive scan
1c4df06 
Add scan extension to force passive scan.

Signed-off-by: Sachin D Kulkarni <sachin.kulkarni@nordicsemi.no>
@sachinthegreen
samples: cellular: modem_shell: Fix gettopt for Wi-Fi builds
c9dab0e 
Wi-Fi shell now uses getopt from Zephyr which needs an additional header
to be included as modem shell uses FreeBSD's port of getopt (downstream
only).

For Wi-Fi switch to using Zephyr's getopt and include the necessary
header file.

Signed-off-by: Sachin D Kulkarni <sachin.kulkarni@nordicsemi.no>
@NordicBuilder NordicBuilder removed the DNM label Aug 24, 2023
@rlubos rlubos merged commit acc4efc into nrfconnect:main Aug 24, 2023
30 of 31 checks passed
@junqingzou junqingzou mentioned this pull request Aug 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trantanen trantanen trantanen left review comments

@rlubos rlubos rlubos left review comments

@muraliThokala muraliThokala muraliThokala approved these changes

@udaynordic udaynordic udaynordic approved these changes

@rado17 rado17 rado17 approved these changes

@krish2718 krish2718 krish2718 approved these changes

@glarsennordic glarsennordic glarsennordic approved these changes

@richabp richabp richabp approved these changes

@plskeggs plskeggs Awaiting requested review from plskeggs

@jayteemo jayteemo Awaiting requested review from jayteemo

@jhirsi jhirsi Awaiting requested review from jhirsi jhirsi is a code owner

@tokangas tokangas Awaiting requested review from tokangas tokangas is a code owner

@carlescufi carlescufi Awaiting requested review from carlescufi

@tejlmand tejlmand Awaiting requested review from tejlmand

@srinivas1201 srinivas1201 Awaiting requested review from srinivas1201

@SeppoTakalo SeppoTakalo Awaiting requested review from SeppoTakalo

@simensrostad simensrostad Awaiting requested review from simensrostad

@jtguggedal jtguggedal Awaiting requested review from jtguggedal

@jhn-nordic jhn-nordic Awaiting requested review from jhn-nordic

@coderbyheart coderbyheart Awaiting requested review from coderbyheart

@krga2022 krga2022 Awaiting requested review from krga2022

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval. manifest manifest-zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.