net: nrf_provisioning: Improve logging #12017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
SeppoTakalo
reviewed
Aug 14, 2023
| /* 'ERROR' or '+CME ERROR'. Doesn't matter which */ | ||
| LOG_INF("AT cmd failed, type %d, err %d", | ||
| LOG_DBG("AT cmd failed, type %d, err %d", |
There was a problem hiding this comment.
LOG_ERR might be better.
There was a problem hiding this comment.
This debug print shows also CME errors which will be filtered out. I added check and error print if CME error was not filtered.
SeppoTakalo
approved these changes
Aug 14, 2023
SeppoTakalo
removed
the
changelog-entry-required
Add some prints to show provisioning steps. Fix log from CME error filtering. Signed-off-by: Juha Ylinen <juha.ylinen@nordicsemi.no>
juhaylinen
force-pushed
the
provisioning_logs
branch
from
b589854
to
93da33d
Compare
github-actions
bot
added
the
changelog-entry-required
juhaylinen
removed
the
changelog-entry-required
jheiskan81
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some prints to show provisioning steps.
Fix log from CME error filtering.