pm: Fix shared SRAM calculation #12018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish2718
requested review from
rado17,
sachinthegreen,
ajayparida,
VivekUppunda and
kapbh
github-actions
bot
added
changelog-entry-required
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
All integration tests: null Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
krish2718
force-pushed
the
fix_thingy53_avail_ram
branch
from
b8e2bc9
to
0a37e74
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
VivekUppunda
approved these changes
Aug 14, 2023
sachinthegreen
approved these changes
Aug 14, 2023
krish2718
force-pushed
the
fix_thingy53_avail_ram
branch
from
0a37e74
to
c9ad6ab
Compare
krish2718
force-pushed
the
fix_thingy53_avail_ram
branch
from
c9ad6ab
to
233ae3f
Compare
krish2718
changed the title
nRF5340 by default has 64KB shared SRAM enabled in the DTS independent of whether IPC service to CPUNET is enabled or not. But when PM is enabled it includes shared SRAM only when IPC service is enabled, this wrongly causes the PM to include shared SRAM in to total available SRAM. To fix, always include the PM configuration file for IPC shared memory to account for the shared SRAM. Fixes NCSDK-23152. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
force-pushed
the
fix_thingy53_avail_ram
branch
from
233ae3f
to
54af351
Compare
hakonfam
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the available RAM print in the memory footprint at end of the build.