application: nrf5340_audio: Fix num_conn not initialized #12019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rick1082
requested review from
koffes,
alexsven,
erikrobstad and
gWacey
as code owners
github-actions
bot
added
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
alexsven
approved these changes
Aug 11, 2023
alexsven
removed
the
changelog-entry-required
cvinayak
approved these changes
Aug 11, 2023
| @@ -75,7 +75,7 @@ static void connected_cb(struct bt_conn *conn, uint8_t err) | |||
| { | |||
| int ret; | |||
| char addr[BT_ADDR_LE_STR_LEN]; | |||
| uint8_t num_conn; | |||
| uint8_t num_conn = 0; | |||
There was a problem hiding this comment.
Suggested change
| uint8_t num_conn = 0; | |
| uint8_t num_conn = 0U; |
There was a problem hiding this comment.
We generally do not use 'U' in the audio application
erikrobstad
approved these changes
Aug 11, 2023
koffes
approved these changes
Aug 11, 2023
Fix num_conn not initialized properly which could cause the CIS gateway cannot establish connection properly. Fix zbus publish wait time in le_audio_event_publish. Signed-off-by: Jui-Chou Chung <jui-chou.chung@nordicsemi.no>
rick1082
force-pushed
the
OCT-NONE-initialize-num-conn-properly
branch
from
5dcf6b8
to
1a7db0c
Compare
github-actions
bot
added
the
changelog-entry-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed num_conn not initialized properly which could cause the CIS gateway cannot establish connection properly.