Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: lwm2m_client_utils: Fix race condition on Firmware object #12022

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

jheiskan81
Copy link
Contributor

@jheiskan81 jheiskan81 commented Aug 11, 2023

net: lwm2m: Fix race condition on Firmware object

Fix possible race conditions when state and results are written
by locking the registry, so a first write does not cause Notify message
to be send too early.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 11, 2023
@jheiskan81
Copy link
Contributor Author

@SeppoTakalo @juhaylinen @rlubos Please review this fix.

@jheiskan81 jheiskan81 removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 11, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 11, 2023

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

Copy link
Contributor

@rlubos rlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please fix the commit message (see compliance).

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 11, 2023
@jheiskan81 jheiskan81 removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 11, 2023
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 14, 2023
@jheiskan81 jheiskan81 removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 14, 2023
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 14, 2023
@jheiskan81 jheiskan81 changed the title net: lwm2m_client_utils: Fix Multiresource write race condition net: lwm2m_client_utils: Fix race condition on Firmware object Aug 14, 2023
@jheiskan81 jheiskan81 removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 14, 2023
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 14, 2023
@SeppoTakalo SeppoTakalo removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 14, 2023
Fix possible race conditions when state and results are written
by locking the registry, so a first write does not cause Notify
message to be send too early.

Signed-off-by: Juha Heiskanen <juha.heiskanen@nordicsemi.no>
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 16, 2023
@nordicjm nordicjm merged commit 0c1077b into nrfconnect:main Aug 16, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants