-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: lwm2m_client_utils: Fix race condition on Firmware object #12022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jheiskan81
requested review from
rlubos,
SeppoTakalo and
juhaylinen
as code owners
August 11, 2023 12:38
github-actions
bot
added
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Aug 11, 2023
@SeppoTakalo @juhaylinen @rlubos Please review this fix. |
jheiskan81
removed
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Aug 11, 2023
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
SeppoTakalo
approved these changes
Aug 11, 2023
rlubos
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please fix the commit message (see compliance).
jheiskan81
force-pushed
the
lwm2m_firmware_fix
branch
from
August 11, 2023 12:46
dc5bb92
to
ae2af00
Compare
github-actions
bot
added
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Aug 11, 2023
jheiskan81
removed
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Aug 11, 2023
jheiskan81
force-pushed
the
lwm2m_firmware_fix
branch
from
August 14, 2023 07:38
ae2af00
to
489bfe0
Compare
github-actions
bot
added
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Aug 14, 2023
juhaylinen
approved these changes
Aug 14, 2023
jheiskan81
removed
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Aug 14, 2023
jheiskan81
force-pushed
the
lwm2m_firmware_fix
branch
from
August 14, 2023 10:18
489bfe0
to
00366c7
Compare
github-actions
bot
added
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Aug 14, 2023
jheiskan81
changed the title
net: lwm2m_client_utils: Fix Multiresource write race condition
net: lwm2m_client_utils: Fix race condition on Firmware object
Aug 14, 2023
jheiskan81
removed
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Aug 14, 2023
jheiskan81
force-pushed
the
lwm2m_firmware_fix
branch
from
August 14, 2023 12:17
00366c7
to
5b7049b
Compare
github-actions
bot
added
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Aug 14, 2023
SeppoTakalo
approved these changes
Aug 14, 2023
SeppoTakalo
removed
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Aug 14, 2023
Fix possible race conditions when state and results are written by locking the registry, so a first write does not cause Notify message to be send too early. Signed-off-by: Juha Heiskanen <juha.heiskanen@nordicsemi.no>
jheiskan81
force-pushed
the
lwm2m_firmware_fix
branch
from
August 16, 2023 07:22
5b7049b
to
6e9c2d3
Compare
github-actions
bot
added
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net: lwm2m: Fix race condition on Firmware object
Fix possible race conditions when state and results are written
by locking the registry, so a first write does not cause Notify message
to be send too early.