nrf_security: Check for existence of RNG driver at build time #12023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for existence of an RNG driver at build time. This moves input validation from runtime to build time. We take psa_driver_wrapper_get_random functions that just return "not supported" out of the build as this should be detected at build time, not runtime. Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
SebastianBoe
requested review from
frkv,
Vge0rge,
vili-nordic,
joerchan and
mswarowsky
as code owners
github-actions
bot
added
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
mswarowsky
approved these changes
Aug 11, 2023
|
It is awkward to do this because the cryptocell binary has a reference to psa_generate_random. Closing. We can improve this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for existence of an RNG driver at build time.
This moves input validation from runtime to build time.
We take psa_driver_wrapper_get_random functions that just return "not supported" out of the build as this should be detected at build time, not runtime.