Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang review workflow #12053

Closed

Commits on Aug 14, 2023

  1. workflow: Add workflow that rebases from ncs/main and creates a PR

    Add workflow that rebases from ncs/main and creates a PR
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    430e0ca View commit details
    Browse the repository at this point in the history
  2. workflow: Add sonarcloud workflow

    Add sonarcloud workflow
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    c30b910 View commit details
    Browse the repository at this point in the history
  3. workflow: sonarcloud: Add code coverage option

    The workflow now invokes sonarcloud with coverage option.
    This will make sonarcloud UI show code coverage data.
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    511a9c3 View commit details
    Browse the repository at this point in the history
  4. workflow: sonarcloud: Fix code coverage report generation for atv2

    Removed building of atv2 on all integration platforms because I am not
    sure if invoking build wrapper twice, once for building atv2 for
    integration platforms and once again for native_posix will work.
    
    Run tests separately after building. Running the tests under build
    wrapper fails mysterously for certain tests (lwm2m_* tests).
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    9bd7126 View commit details
    Browse the repository at this point in the history
  5. workflow: rebase_to_ncs_main work flow will now create draft PRs

    This avoids code owners (with access to my fork)  getting PR requests.
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    a27e34d View commit details
    Browse the repository at this point in the history
  6. workflow: sonarcloud: Run all native_posix tests in sdk-nrf repo

    Run all native_posix tests in sdk-nrf repo.
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    704f379 View commit details
    Browse the repository at this point in the history
  7. workflow: sonarcloud: Exclude modules

    Exclude modules from analysis.
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    191993e View commit details
    Browse the repository at this point in the history
  8. workflow: Expand the scope of sonarcloud to include integration tests

    Expand the scope of sonarcloud to include integration tests. This has to
    be run on self-hosted setup because github actions does not have the
    resources to handle large twister runs.
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    d3b6233 View commit details
    Browse the repository at this point in the history
  9. workflow: sonarcloud: Exclude zephyr folder

    We dont want to analyse zephyr repo
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    3a68843 View commit details
    Browse the repository at this point in the history
  10. workflow: sonarcloud: Remove native_posix tests and code cov

    And also the code coverage
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    0db223b View commit details
    Browse the repository at this point in the history
  11. workflow: Revert "workflow: sonarcloud: Remove native_posix tests"

    This reverts commit beb643f.
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    eac82e8 View commit details
    Browse the repository at this point in the history
  12. workflow: sonarcloud: Enable -X when calling sonarscanner

    This is to make it produce debug output
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    0c7cbe0 View commit details
    Browse the repository at this point in the history
  13. workflow: sonarcloud: Ignore vsdx files

    Ignore vsdx files
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    abb6d7e View commit details
    Browse the repository at this point in the history
  14. workflow: sonarcloud: Clobber output when running unit tests

    Clobber output when running unit tests
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    c7aa481 View commit details
    Browse the repository at this point in the history
  15. workflow: sonarcloud: Invoke twister with -i

    This is to make it print failures inline
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    7c1e65f View commit details
    Browse the repository at this point in the history
  16. workflow: Trigger sonarcloud only on native_posix tests on PR

    Created a new workflow file that runs sonarcloud by only invoking
    twister for native_posix tests. The sonarcloud analysis on main branch
    will run twister with integration scope and will take longer time to
    complete.
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    86f95b1 View commit details
    Browse the repository at this point in the history
  17. workflow: sonarcloud-pr: Add quarantine-list parameter

    This is mainly to exclude any failing unit tests
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    ad5b640 View commit details
    Browse the repository at this point in the history
  18. workflow: Run native_posix build also on main

    Run native_posix tests on main so that sonarcloud
    gets some info about main branch.
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    76c9258 View commit details
    Browse the repository at this point in the history
  19. workflow: Rename sonarcloud-pr to sonarcloud-native-posix

    Renamed to reflect what it does
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    17d061b View commit details
    Browse the repository at this point in the history
  20. workflow: Do not include quarentined tests

    This was done in sonarcloud for PR. Doing this in
    main sonarcloud now.
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    9dc9b00 View commit details
    Browse the repository at this point in the history
  21. workflow: Dont run native_posix analysis on push to main

    We have another workflow that runs sonarcloud on integration scope on
    pushes to main
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    159f972 View commit details
    Browse the repository at this point in the history
  22. workflow: Exclude zephyr from code coverage collection

    Exclude zephyr from code coverage collection
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    ebc20d3 View commit details
    Browse the repository at this point in the history
  23. workflow: Make gcov output verbose output

    This is to debug any possible future failures
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    c7d756e View commit details
    Browse the repository at this point in the history
  24. coverage: add sockets_tls.c to ignore list

    This was causing gcovr to fail with an assert. Its a known issue
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    e83e12a View commit details
    Browse the repository at this point in the history
  25. workflow: Move common parts of sonarcloud and sonarcloud-native-posix

    They are now moved to sonar-project.properties file
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    d8338aa View commit details
    Browse the repository at this point in the history
  26. workflow: Add chatgpt review workflow

    Add chatgpt review workflow
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    a55cfbd View commit details
    Browse the repository at this point in the history
  27. workflow: Include python code in the sonarcloud analysis

    Include python code in the sonarcloud analysis
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    ffae662 View commit details
    Browse the repository at this point in the history
  28. workflow: Create separate quarentine file for downsream

    This is to avoid conflicts due to changes in upstream
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    9188e5c View commit details
    Browse the repository at this point in the history
  29. workflow: Create codeql.yml for security analysis of c and python code

    Create codeql.yml for security analysis of c and python code
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    fb89bbb View commit details
    Browse the repository at this point in the history
  30. quarentine_downstream: Remove mesh test from quarentine

    It has been fixed in ncs/main
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    8dce354 View commit details
    Browse the repository at this point in the history
  31. workflows: Make codeql run every day at 12am

    Make codeql run every day at 12am
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    15654a4 View commit details
    Browse the repository at this point in the history
  32. workflows: Remove chatgpt review workflow

    The usage limit for the API expired for my acc. So removing this.
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    7951fb7 View commit details
    Browse the repository at this point in the history
  33. quarentine: Remove a test and add another

    lwm2m_code test was fixed long time back. Removing from quarentine.
    But the download_client test started failing on docker on github actions
    (passes locally even in docker). My guess is that the failure is because
    of ioctl call return 2 because docker was not run in privilaged mode by
    github actions. Disabling now.
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    98ea1ce View commit details
    Browse the repository at this point in the history
  34. workflow: Allow sonarcloud-native-posix to run on PRs from forks

    Changed pull_request to pull_request_target
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    84d9fff View commit details
    Browse the repository at this point in the history
  35. workflow: Run sonarcloud-native_posix also on push to main

    This is done because I have not disabled the sonarcloud (all platforms)
    workflow on main.
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    42071fa View commit details
    Browse the repository at this point in the history
  36. workflow: sonarcloud: Fix sonarcloud run on PRs from fork

    - Use PR's head sha when checking out code when triggered from PR.
    - Provided the PR number, head ref, sha to sonarcloud so that it
    consideres the run as a PR run. It would not treat pull_request_target
    events as a PR and hence wont do PR decoration if not done this way
    - Also when building/running unit tests on PRs, we should not use
    quarentine_downstream.yaml file as it is not available on the PR's
    branch.
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    07886e4 View commit details
    Browse the repository at this point in the history
  37. workflows: sonarcloud: Ignore test run failure on PRs.

    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    71aee02 View commit details
    Browse the repository at this point in the history
  38. fixup: download sonar-project props and quarentine

    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    454a5f9 View commit details
    Browse the repository at this point in the history
  39. workflow: Remove gcc-multilib installation

    It is now included in the docker image
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    1f53beb View commit details
    Browse the repository at this point in the history
  40. workflow: Use sonarcloud-github-c-cpp action

    Saves a lot of manual steps in the workflow
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    4b6f89e View commit details
    Browse the repository at this point in the history
  41. Workflow: sonarcloud: Remove unused env variables

    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    09e9651 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. workflow: Add clang-tidy review workflow

    Add clang-tidy review workflow
    
    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    1716bf5 View commit details
    Browse the repository at this point in the history
  2. fixup:

    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    0242329 View commit details
    Browse the repository at this point in the history
  3. fixup: ruby

    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    2d82752 View commit details
    Browse the repository at this point in the history
  4. fixup: paths

    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    65a4f07 View commit details
    Browse the repository at this point in the history
  5. test change

    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    12d9b5d View commit details
    Browse the repository at this point in the history
  6. make clang tidy result dir

    Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
    Balaji Srinivasan committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    492518f View commit details
    Browse the repository at this point in the history