Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applications: Matter Bridge: added BLE environmental sensor support #12074

Merged
merged 1 commit into from
Aug 25, 2023
Merged

applications: Matter Bridge: added BLE environmental sensor support #12074

merged 1 commit into from
Aug 25, 2023

Conversation

markaj-nordic
Copy link
Contributor

  • Added implementation of the BLE data provider which supports subscription to the humidity and temperature characteristics.
  • implemented one provider to many Matter devices relation
  • updated README

@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. labels Aug 18, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 18, 2023 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-chip X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

kkasperczyk-no
kkasperczyk-no reviewed Aug 21, 2023
View reviewed changes
applications/matter_bridge/README.rst Outdated Show resolved Hide resolved
applications/matter_bridge/README.rst Outdated Show resolved Hide resolved
samples/matter/common/src/bridge/bridged_device.h Show resolved Hide resolved
samples/matter/common/src/bridge/bridge_manager.cpp Outdated Show resolved Hide resolved
samples/matter/common/src/bridge/bridge_manager.cpp Outdated Show resolved Hide resolved
@markaj-nordic markaj-nordic force-pushed the matter_bridge_ble_es_support branch 2 times, most recently from 0d6a3e4 to 9c5d540 Compare August 23, 2023 18:58
wiba-nordic
wiba-nordic requested changes Aug 24, 2023
View reviewed changes
applications/matter_bridge/README.rst Outdated Show resolved Hide resolved
applications/matter_bridge/README.rst Outdated Show resolved Hide resolved
applications/matter_bridge/README.rst Show resolved Hide resolved
applications/matter_bridge/README.rst Outdated Show resolved Hide resolved
applications/matter_bridge/README.rst Outdated Show resolved Hide resolved
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

wiba-nordic
wiba-nordic approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@wiba-nordic wiba-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs are good.

kkasperczyk-no
kkasperczyk-no reviewed Aug 24, 2023
View reviewed changes
applications/matter_bridge/Kconfig Outdated Show resolved Hide resolved
applications/matter_bridge/src/bridge_shell.cpp Outdated Show resolved Hide resolved
applications/matter_bridge/src/bridge_shell.cpp Outdated Show resolved Hide resolved
applications/matter_bridge/src/bridged_device_types/ble_environmental_data_provider.cpp Show resolved Hide resolved
applications/matter_bridge/src/bridged_device_types/ble_environmental_data_provider.cpp Outdated Show resolved Hide resolved
applications/matter_bridge/src/bridged_device_types/ble_environmental_data_provider.cpp Outdated Show resolved Hide resolved
samples/matter/common/src/bridge/bridge_manager.cpp Outdated Show resolved Hide resolved
samples/matter/common/src/bridge/bridge_manager.cpp Outdated Show resolved Hide resolved
@wiba-nordic
Copy link
Contributor

Almost forgot, but this should have a changelog entry.

@markaj-nordic
applications: Matter Bridge: added BLE environmental sensor support
d583ba6 
* Added implementation of the BLE data provider which supports
  subscription to the humidity and temperature characteristics.
* implemented one provider to many Matter devices relation
* updated README

Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no>
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 25, 2023
@markaj-nordic
Copy link
Contributor Author

Almost forgot, but this should have a changelog entry.

Done.

@LuDuda LuDuda merged commit cebfcb4 into nrfconnect:main Aug 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArekBalysNordic ArekBalysNordic ArekBalysNordic approved these changes

@wiba-nordic wiba-nordic wiba-nordic approved these changes

@kkasperczyk-no kkasperczyk-no kkasperczyk-no approved these changes

@LuDuda LuDuda Awaiting requested review from LuDuda

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@tejlmand tejlmand Awaiting requested review from tejlmand

@carlescufi carlescufi Awaiting requested review from carlescufi

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@markaj-nordic @NordicBuilder @wiba-nordic @kkasperczyk-no @ArekBalysNordic @LuDuda