-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: nrf9131ek board files #12080
wip: nrf9131ek board files #12080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some replacing of 9161 needs to be done. The big question is if we should have a 9131 SOC definiton
# Copyright (c) 2023 Nordic Semiconductor ASA | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
if SOC_NRF9161_SICA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should there be a new SOC also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question! technically, it shouldn't be necessary, but it could be for documentation reasons. we could also nename nRF9161 to nRF91X1. Who would decide this?
boards/arm/nrf9131ek_nrf9131/nrf9131ek_nrf9131_partition_conf.dtsi
Outdated
Show resolved
Hide resolved
Soc definition is quite lightweight https://github.com/zephyrproject-rtos/zephyr/blob/2fe449356488808ac98b56908eddba36c16b7e95/soc/arm/nordic_nrf/nrf91/Kconfig.soc#L29 |
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
675ab4d
to
4389286
Compare
Created a zephyr PR for the new SOC. Let's see how that goes: zephyrproject-rtos/zephyr#61724 |
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
No description provided.