Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFC platform hardfault fix #12101

Merged
merged 2 commits into from
Aug 24, 2023
Merged

NFC platform hardfault fix #12101

merged 2 commits into from
Aug 24, 2023

Conversation

KAGA164
Copy link
Contributor

@KAGA164 KAGA164 commented Aug 22, 2023

Fixed the issue where an assertion could be triggered when requesting clock from the NFC platform interrupt context.

@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Aug 22, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 22, 2023

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-nfc X
test-sdk-find-my X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

Copy link
Contributor

@peknis peknis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a nit.

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

.. rst-class:: v2-4-1 v2-4-0 v2-3-0

NCSDK-22799: Assert when requesting clock from the NFC interrupt context.
The NFC interrupt is a low latency interrupt and calls Zephyr subsystem API that rarely can cause undefined behavior.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The NFC interrupt is a low latency interrupt and calls Zephyr subsystem API that rarely can cause undefined behavior.
The NFC interrupt is a low latency interrupt.
It calls the Zephyr subsystem API that can rarely cause undefined behavior.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

The NFC interrupt was a zero latency interrupt and
it calls Zephyr subsystem API that causes rare
undefined behavior. This fixes it and removes
zero latency flag for the NFC interrupt.

NCSDK-22799

Signed-off-by: Kamil Gawor <Kamil.Gawor@nordicsemi.no>
This updates documentation with fixes
for the NFC platform interrupt priorities.

NCSDK-22799

Signed-off-by: Kamil Gawor <Kamil.Gawor@nordicsemi.no>
@rlubos rlubos merged commit eb1bdc7 into nrfconnect:main Aug 24, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants