Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: wifi: Optimize the memory consumed by logs #12122

Merged
merged 2 commits into from
Sep 1, 2023
Merged

drivers: wifi: Optimize the memory consumed by logs #12122

merged 2 commits into from
Sep 1, 2023

Conversation

rado17
Copy link
Contributor

@rado17 rado17 commented Aug 23, 2023

Limit the information displayed in logging (function, line etc.). Disable printing of debug message by default.

@rado17 rado17 added this to the 2.5.0 milestone Aug 23, 2023
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 23, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 23, 2023 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-chip X
test-sdk-wifi X

test-sdk-wifi: added because there was no .github/test-spec.yml in 'hostap'

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 23, 2023 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hostap nrfconnect/sdk-hostap@44c4504 nrfconnect/sdk-hostap@8b0abe8 (main) nrfconnect/sdk-hostap@44c4504d..8b0abe8f

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

krish2718
krish2718 requested changes Aug 24, 2023
View reviewed changes
drivers/wifi/nrf700x/Kconfig Outdated Show resolved Hide resolved
modules/hostap/Kconfig Outdated Show resolved Hide resolved
markaj-nordic
markaj-nordic reviewed Aug 24, 2023
View reviewed changes
Copy link
Contributor

@markaj-nordic markaj-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Matter we have WPA_SUPP_NO_DEBUG already set by default:

https://github.com/nrfconnect/sdk-connectedhomeip/blob/master/config/nrfconnect/chip-module/Kconfig.defaults#L250

@rado17
Copy link
Contributor Author

rado17 commented Aug 25, 2023

For Matter we have WPA_SUPP_NO_DEBUG already set by default:

https://github.com/nrfconnect/sdk-connectedhomeip/blob/master/config/nrfconnect/chip-module/Kconfig.defaults#L250

Will drop this commit.

@rado17 rado17 requested a review from krish2718 August 25, 2023 07:36
@LuDuda
Copy link
Contributor

LuDuda commented Aug 25, 2023

Thank you for this improvement! 👍

As discussed F2F - introduction of CONFIG_NRF700X_LOG_VERBOSE is a good improvement for debug variants. Still however, we don't have control over log level in the Wi-Fi OSAL layer. E.g. even if LOGS are completely off (release build), log strings will occupy the flash memory. It would be perfect to have Zephyr based logging approach there.

LuDuda
LuDuda approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@rado17
drivers: wifi: Optimize the memory consumed by logs
501032b 
Limit the information displayed in logging (function, line etc.).
Disable printing of debug message by default.

Signed-off-by: Ravi Dondaputi <ravi.dondaputi@nordicsemi.no>
@rado17
manifest: sdk-hostap: Pull log optimizations
f826d9f 
Pull the memory optimization changes done by protecting
the log related calls at compile time.

Signed-off-by: Ravi Dondaputi <ravi.dondaputi@nordicsemi.no>
@NordicBuilder NordicBuilder removed the DNM label Sep 1, 2023
@rlubos rlubos merged commit fd5c34a into nrfconnect:main Sep 1, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VivekUppunda VivekUppunda VivekUppunda approved these changes

@sachinthegreen sachinthegreen sachinthegreen approved these changes

@krish2718 krish2718 krish2718 approved these changes

@markaj-nordic markaj-nordic markaj-nordic approved these changes

@LuDuda LuDuda LuDuda approved these changes

@ajayparida ajayparida Awaiting requested review from ajayparida

@kapbh kapbh Awaiting requested review from kapbh

@tejlmand tejlmand Awaiting requested review from tejlmand

@rlubos rlubos Awaiting requested review from rlubos

@carlescufi carlescufi Awaiting requested review from carlescufi

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-hostap
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
8 participants
@rado17 @NordicBuilder @LuDuda @markaj-nordic @krish2718 @sachinthegreen @VivekUppunda @rlubos