nrf_security: Remove secp521r1 Kconfig #12123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mswarowsky
requested review from
frkv,
Vge0rge,
vili-nordic,
joerchan and
SebastianBoe
as code owners
github-actions
bot
added
the
changelog-entry-required
joerchan
approved these changes
Aug 23, 2023
SebastianBoe
approved these changes
Aug 23, 2023
mswarowsky
force-pushed
the
remove_secp521r1
branch
from
2da9bcb
to
5ba7e6c
Compare
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
mswarowsky
removed
the
changelog-entry-required
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
github-actions
bot
added
the
changelog-entry-required
mswarowsky
force-pushed
the
remove_secp521r1
branch
from
e94114a
to
14b9088
Compare
The config option give the impression that cryptocell supports secp521r1 but it doesn't so removing the Kconfig to make the Kconfig options more aligned to the actual capabilities. Ref: NCSDK-21666 Signed-off-by: Markus Swarowsky <markus.swarowsky@nordicsemi.no>
mswarowsky
force-pushed
the
remove_secp521r1
branch
from
14b9088
to
2946b51
Compare
PSA_VENDOR_ECC_MAX_CURVE_BITS gets in already defined in the autogenerated nrf-config-user.h and if these defines don't match it results in a redefined warning Ref: NCSDK-21666 Signed-off-by: Markus Swarowsky <markus.swarowsky@nordicsemi.no>
mswarowsky
force-pushed
the
remove_secp521r1
branch
from
2946b51
to
d950b86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config option give the impression that cryptocell supports secp521r1 but it doesn't so removing the Kconfig to make the Kconfig options more aligned to the actual capabilities.