samples: bluetooth: encrypt throughput sample

[martintv]

By the same logic we used when we decided to encrypt the llpm sample in #11720
we should also encrypt throughput sample. We should demonstrate the throughput we can get, with encryption on.

And conenct with 7.5ms interval to speed up encryption. The sample will switch to the interval selected by console (or 400ms if nothing is selected) before doing the throgputmeasurment.

Currently failing sample nightly test run, so that needs to be looked into before mergeing. https://jenkins-ncs.nordicsemi.no/blue/organizations/jenkins/latest%2Fsub%2Ftest-fw-nrfconnect-ble_samples/detail/master/9307/pipeline/

Disconnect with BT_HCI_ERR_INSTANT_PASSED

[NordicBuilder]

Test specification

CI/Jenkins/NRF

• Integration Platforms

CI/Jenkins/integration

Test Module	File based changes	Manually selected	West overwrite
test-fw-nrfconnect-ble	X
test-fw-nrfconnect-ble_samples	X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

[KAGA164]

Could security be enabled through Kconfig? The default option can be that encryption is always on.

[martintv]

Could security be enabled through Kconfig? The default option can be that encryption is always on.

we could do that, but we didnt for the llpm sample. I think we should just enable it, without kconfig. In the spirit that security shouldn't be optional. if anyone wants to turn it off for some reason, its easy to remove the call to bt_conn_set_security, but we shouldn't encourage that imo...

but I don't have so strong feeling here, I could add Kconfig, but we shuold do the same for llpm sample then

[grochu]

Please document the update in the changelog: https://github.com/nrfconnect/sdk-nrf/blob/main/doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

[martintv]

Please document the update in the changelog: https://github.com/nrfconnect/sdk-nrf/blob/main/doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

had a look, its confusing, Im 100% sure I would do it wrong, can whoever was going to review it do it themselfs? techwriter probably?

[jori-nordic]

is this to get the data length update instant faster?

[martintv]

yes, and encrypting the link faster on initial connection.

[grochu]

had a look, its confusing, Im 100% sure I would do it wrong, can whoever was going to review it do it themselfs? techwriter probably?

I'd propose this:
":ref:ble_throughput sample:

• Enabled encryption in the sample - the measured throughput is calculated over the encrypted data, which is how most of the Bluetooth products use this protocol."

@peknis could you please check this statement? Adding you as reviewer of this PR. Thanks
@martintv the text will depend on whether you decide to add a Kconfig option there.

Pekka says: Looks ok to me. Just add the entry to the changelog file. I will then check it once again.

[peknis]

Suggested change

	* Enabled encryption in the sample - the measured throughput is calculated over the encrypted data, which is how most of the Bluetooth products use this protocol.
	* Enabled encryption in the sample.
	The measured throughput is calculated over the encrypted data, which is how most of the Bluetooth products use this protocol.

[NordicBuilder]

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.