Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: nrf_modem: v2.5.0 release #12425

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

eivindj-nordic
Copy link
Contributor

@eivindj-nordic eivindj-nordic commented Sep 25, 2023

See CHANGELOG file in nrfxlib for details about library features.

nrfconnect/sdk-nrfxlib#1079
nrfconnect/sdk-zephyr#1316

test-sdk-nrf: sdk-nrf-pr-12425

* CEREG event tracking to ``lte_connectivity``.
* The :c:macro:`NRF_MODEM_LIB_ON_DFU_RES` macro to add callbacks for modem DFU results.

* Replaced the use of :c:macro:`SO_BINDTODEVICE` socket option with :c:macro:`SO_BINDTOPDN` to bind the socket to a PDN. The new option takes an integer for the PDN ID instead of a string.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Replaced the use of :c:macro:`SO_BINDTODEVICE` socket option with :c:macro:`SO_BINDTOPDN` to bind the socket to a PDN. The new option takes an integer for the PDN ID instead of a string.
* Replaced the use of :c:macro:`SO_BINDTODEVICE` socket option with :c:macro:`SO_BINDTOPDN` to bind the socket to a PDN.
The new option takes an integer for the PDN ID instead of a string.

@eivindj-nordic eivindj-nordic force-pushed the libmodem_v2.5.0 branch 7 times, most recently from 16f3b16 to 5f89cd9 Compare October 5, 2023 08:01
printk("Modem already initialized\n");
return;
default:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need the default back

@eivindj-nordic eivindj-nordic force-pushed the libmodem_v2.5.0 branch 5 times, most recently from 86cf149 to 84ddabf Compare October 6, 2023 11:04
Copy link
Contributor

@lemrey lemrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@eivindj-nordic eivindj-nordic force-pushed the libmodem_v2.5.0 branch 2 times, most recently from 0c767b8 to a8f8bfc Compare October 6, 2023 11:43
Copy link
Contributor

@rlubos rlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update SHAs and rebase

west.yml Outdated Show resolved Hide resolved
west.yml Outdated Show resolved Hide resolved
See CHANGELOG file in nrfxlib for details about library features.

Co-authored-by: Emanuele Di Santo <emdi@nordicsemi.no>
Co-authored-by: Tommi Kangas <tommi.kangas@nordicsemi.no>
Signed-off-by: Eivind Jølsgard <eivind.jolsgard@nordicsemi.no>
@rlubos rlubos merged commit 513042b into nrfconnect:main Oct 6, 2023
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval. manifest manifest-nrfxlib manifest-zephyr
Projects
None yet
Development

Successfully merging this pull request may close these issues.