Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Rename nRF91 AT Commands Reference Guide #12489

Merged
merged 1 commit into from
Oct 6, 2023
Merged

doc: Rename nRF91 AT Commands Reference Guide #12489

merged 1 commit into from
Oct 6, 2023

Conversation

divipillai
Copy link
Contributor

  • Rename "nRF91 AT Commands Reference Guide" to "nRF9160 AT Commands".
  • Add AT Commands Reference Guide for the nRF9161 DK.

@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. labels Oct 2, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 2, 2023 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
nrfxlib nrfconnect/sdk-nrfxlib@7096d02 nrfconnect/sdk-nrfxlib@410ca11 (main) nrfconnect/sdk-nrfxlib@7096d029..410ca110

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@divipillai divipillai force-pushed the NCSDK-23496_AT_command branch 2 times, most recently from 976494a to b5c8e5f Compare October 3, 2023 09:17
@divipillai divipillai marked this pull request as ready for review October 3, 2023 09:36
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 3, 2023 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-nrf-iot_cloud X
test-fw-nrfconnect-nrf-iot_mosh X
test-fw-nrfconnect-nrf-iot_samples X
test-fw-nrfconnect-nrf-iot_serial_lte_modem X
test-fw-nrfconnect-nrf-iot_thingy91 X
test-fw-nrfconnect-nrf-iot_zephyr_lwm2m X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

wiba-nordic
wiba-nordic requested changes Oct 3, 2023
View reviewed changes
doc/nrf/libraries/modem/lte_lc.rst Outdated Show resolved Hide resolved
doc/nrf/libraries/modem/modem_battery.rst Outdated Show resolved Hide resolved
@tomi-font tomi-font removed the request for review from VTPeltoketo October 3, 2023 10:24
@tomi-font tomi-font removed their request for review October 3, 2023 10:24
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 5, 2023
@divipillai divipillai force-pushed the NCSDK-23496_AT_command branch 2 times, most recently from 46db5ec to 0728f86 Compare October 5, 2023 15:20
@divipillai divipillai removed the DNM label Oct 6, 2023
@divipillai divipillai removed the DNM label Oct 6, 2023
@divipillai divipillai added this to the 2.5.0 milestone Oct 6, 2023
rlubos
rlubos reviewed Oct 6, 2023
View reviewed changes
west.yml Outdated
@@ -141,7 +141,7 @@ manifest:
- name: nrfxlib
repo-path: sdk-nrfxlib
path: nrfxlib
revision: 7096d02995dc7ea140340aa473ff1754d7257292
revision: pull/1084/head
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update SHA: 410ca110e209c1c1050d613d1f61c6eab6d171df

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@divipillai
doc: Rename nRF91 AT Commands Reference Guide
b4d5e98 
* Rename "nRF91 AT Commands Reference Guide" to "nRF9160 AT Commands".
* Add AT Commands Reference Guide for the nRF9161 DK.

Signed-off-by: divya pillai <divya.pillai@nordicsemi.no>
@rlubos rlubos merged commit 93f3d54 into nrfconnect:main Oct 6, 2023
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkusLassila MarkusLassila MarkusLassila approved these changes

@glarsennordic glarsennordic glarsennordic approved these changes

@wiba-nordic wiba-nordic wiba-nordic approved these changes

@trantanen trantanen trantanen approved these changes

@juhaylinen juhaylinen juhaylinen approved these changes

@rlubos rlubos rlubos approved these changes

@tokangas tokangas tokangas approved these changes

@plskeggs plskeggs plskeggs approved these changes

@jayteemo jayteemo Awaiting requested review from jayteemo

@SeppoTakalo SeppoTakalo Awaiting requested review from SeppoTakalo

@jheiskan81 jheiskan81 Awaiting requested review from jheiskan81

@lemrey lemrey Awaiting requested review from lemrey

@carlescufi carlescufi Awaiting requested review from carlescufi

@tejlmand tejlmand Awaiting requested review from tejlmand

@jhirsi jhirsi Awaiting requested review from jhirsi

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval. manifest manifest-nrfxlib
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
10 participants
@divipillai @NordicBuilder @plskeggs @tokangas @rlubos @juhaylinen @trantanen @wiba-nordic @glarsennordic @MarkusLassila