Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: nrf: Added page about Matter ecosystems certification #12546

Merged
merged 1 commit into from
Oct 11, 2023
Merged

doc: nrf: Added page about Matter ecosystems certification #12546

merged 1 commit into from
Oct 11, 2023

Conversation

kkasperczyk-no
Copy link
Contributor

Added dedicated page describing how to certify the Matter product for the specific ecosystem cases. Additionally extended the FFS configuration with the information about the rotating device uid selection.

@kkasperczyk-no kkasperczyk-no added this to the 2.5.0 milestone Oct 5, 2023
@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. labels Oct 5, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 5, 2023 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Skipped

CI/Jenkins/integration

  • Skipped

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@LuDuda LuDuda added the DNM label Oct 5, 2023
LuDuda
LuDuda reviewed Oct 5, 2023
View reviewed changes
Copy link
Contributor

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Small comments below.

Also please do not merge it yet, until we do have a green light from Wi-Fi FFS cert.

doc/nrf/protocols/matter/end_product/ecosystems_certification.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/end_product/ecosystems_certification.rst Outdated
* Simplified - for products using a certified reference design

The Matter platform provided in the |NCS| was tested against the FFS certification test cases and passed them in several variants.
If you create a Matter product based on |NCS|, you can benefit from it and approach the simplified certification path.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please link to the Amazon certification page? Since it would be nice to understand what "simplified" means - i.e. less testing, no need to send devices to Amazon for lab testing.

Copy link
Contributor Author

@kkasperczyk-no kkasperczyk-no Oct 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a link to the Amazon certification page in this sentence FFS requires passing the additional certification test cases for Matter called Matter Simple Setup_. Do you think it is enough or should we point to some specific part of the page?

doc/nrf/protocols/matter/end_product/ecosystems_certification.rst Outdated Show resolved Hide resolved
@kkasperczyk-no kkasperczyk-no force-pushed the ecosystems_certification_doc branch 2 times, most recently from 8ec229a to db00781 Compare October 6, 2023 05:49
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 6, 2023
wiba-nordic
wiba-nordic requested changes Oct 6, 2023
View reviewed changes
doc/nrf/protocols/matter/end_product/ecosystems_certification.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/end_product/ecosystems_certification.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/end_product/ecosystems_certification.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/end_product/ecosystems_certification.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/end_product/ecosystems_certification.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/end_product/ecosystems_certification.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/getting_started/advanced_kconfigs.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/getting_started/advanced_kconfigs.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/getting_started/advanced_kconfigs.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/getting_started/advanced_kconfigs.rst Outdated Show resolved Hide resolved
wiba-nordic
wiba-nordic requested changes Oct 6, 2023
View reviewed changes
doc/nrf/protocols/matter/end_product/ecosystems_certification.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/end_product/ecosystems_certification.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/end_product/ecosystems_certification.rst Outdated
Comment on lines 59 to 63
| nrf52840dk_nrf52840 (Matter over Thread) | ZNwt |
+-----------------------------------------------+-----------------------+
| nrf5340dk_nrf5340_cpuapp (Matter over Thread) | xzNd |
+-----------------------------------------------+-----------------------+
| nrf7002dk_nrf5340_cpuapp (Matter over Wi-Fi) | jyjh |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be board names (in which case the _cpuapp part should not be included) or build targets (in which case they should be formatted nrf52840dk_nrf52840). For refrence from the the Light bulb sample:
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, actually I think it should be hardware platforms. I updated the table with this change.

doc/nrf/protocols/matter/getting_started/advanced_kconfigs.rst Outdated Show resolved Hide resolved
@kkasperczyk-no kkasperczyk-no force-pushed the ecosystems_certification_doc branch 2 times, most recently from 3074c0c to 388b717 Compare October 9, 2023 08:49
@kkasperczyk-no
Copy link
Contributor Author

kkasperczyk-no commented Oct 9, 2023 •
edited
Loading

@LuDuda as discussed F2F I removed Wi-Fi APID, so I'm removing DNM label.

@kkasperczyk-no kkasperczyk-no removed the DNM label Oct 9, 2023
markaj-nordic
markaj-nordic approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@markaj-nordic markaj-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there is however a licensing warning reported on the first altered file.

@kkasperczyk-no
Copy link
Contributor Author

LGTM, there is however a licensing warning reported on the first altered file.

I'm not sure whether this is really related to my change.

@kkasperczyk-no
doc: nrf: Added page about Matter ecosystems certification
96f43ec 
Added dedicated page describing how to certify the Matter product
for the specific ecosystem cases. Additionally extended the FFS
configuration with the information about the rotating device uid
selection.

Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no>
LuDuda
LuDuda approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Re-adding DNM, awaiting one confirmation.

@LuDuda LuDuda added the DNM label Oct 10, 2023
@rlubos rlubos merged commit 2fa30e5 into nrfconnect:main Oct 11, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuDuda LuDuda LuDuda approved these changes

@wiba-nordic wiba-nordic wiba-nordic approved these changes

@markaj-nordic markaj-nordic markaj-nordic approved these changes

@doublemis1 doublemis1 Awaiting requested review from doublemis1

@ArekBalysNordic ArekBalysNordic Awaiting requested review from ArekBalysNordic

@carlescufi carlescufi Awaiting requested review from carlescufi

@gmarull gmarull Awaiting requested review from gmarull

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
6 participants
@kkasperczyk-no @NordicBuilder @LuDuda @wiba-nordic @markaj-nordic @rlubos