Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: matter: Add documentation for last fabric removal #12558

Merged
merged 1 commit into from
Oct 11, 2023
Merged

doc: matter: Add documentation for last fabric removal #12558

merged 1 commit into from
Oct 11, 2023

Conversation

ArekBalysNordic
Copy link
Contributor

  • Added the page to describe the mechanism and reactions to the last fabric removal.
  • Added instruction on how to implement the custom Fabric Table delegation.
  • Updated the advanced kncofigs pages to describe all possible reactions to the last fabric removal.

@ArekBalysNordic ArekBalysNordic added this to the 2.5.0 milestone Oct 6, 2023
@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. labels Oct 6, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 6, 2023 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Skipped

CI/Jenkins/integration

  • Skipped

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

wiba-nordic
wiba-nordic requested changes Oct 6, 2023
View reviewed changes
doc/nrf/protocols/matter/end_product/last_fabric_removal_delegate.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/end_product/last_fabric_removal_delegate.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/end_product/last_fabric_removal_delegate.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/end_product/last_fabric_removal_delegate.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/end_product/last_fabric_removal_delegate.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/getting_started/advanced_kconfigs.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/getting_started/advanced_kconfigs.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/getting_started/advanced_kconfigs.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/getting_started/advanced_kconfigs.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/getting_started/advanced_kconfigs.rst Outdated Show resolved Hide resolved
@ArekBalysNordic ArekBalysNordic force-pushed the last_fabric_removal_docs branch 2 times, most recently from c0491f0 to 9952596 Compare October 6, 2023 11:55
wiba-nordic
wiba-nordic approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@wiba-nordic wiba-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@ArekBalysNordic ArekBalysNordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 9, 2023
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 10, 2023
@ArekBalysNordic
Copy link
Contributor Author

@wiba-nordic I've provided some changes after f2f discussion with @LuDuda. Could you please check the recent changes? Also @LuDuda could you check whether everything is okay now?

LuDuda
LuDuda approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ArekBalysNordic
doc: matter: Add documentation for last fabric removal
159b775 
- Added the page to describe the mechanism and reactions to
the last fabric removal.
- Added instruction on how to implement the custom Fabric Table
delegation.
- Updated the advanced kncofigs pages to describe all possible
reactions to the last fabric removal.

Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
@ArekBalysNordic ArekBalysNordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 11, 2023
@rlubos rlubos merged commit 359e1f2 into nrfconnect:main Oct 11, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiba-nordic wiba-nordic wiba-nordic approved these changes

@kkasperczyk-no kkasperczyk-no kkasperczyk-no approved these changes

@LuDuda LuDuda LuDuda approved these changes

@markaj-nordic markaj-nordic Awaiting requested review from markaj-nordic

@carlescufi carlescufi Awaiting requested review from carlescufi

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ArekBalysNordic @NordicBuilder @LuDuda @kkasperczyk-no @wiba-nordic @rlubos