ci: Update requirements-fixed.txt format #12631
Conversation
github-actions
bot
added
the
changelog-entry-required
DatGizmo
force-pushed
the
pip-req-format-update
branch
from
19a1b65
to
70a56ed
Compare
|
The changes to the 'requirements-fixed.txt' have been added to this PR. Note: This comment is automatically posted and updated by the Comment GitHub Action. |
DatGizmo
force-pushed
the
pip-req-format-update
branch
from
b98ff6b
to
b8e0705
Compare
|
|
DatGizmo
force-pushed
the
pip-req-format-update
branch
from
c19b064
to
edcb057
Compare
DatGizmo
requested review from
tejlmand,
grho,
shanthanordic and
ihansse
as code owners
DatGizmo
requested review from
karhama
and removed request for
ihansse,
grho and
shanthanordic
scripts/requirements-fixed.txt
Outdated
| @@ -2,361 +2,132 @@ | |||
| # This file is autogenerated by pip-compile with Python 3.8 | |||
| # by the following command: | |||
| # | |||
| # pip-compile --allow-unsafe --output-file=requirements-fixed.txt --strip-extras ./bootloader/mcuboot/scripts/requirements.txt ./nrf/scripts/requirements-ci.txt ./nrf/scripts/requirements-extra.txt ./nrf/scripts/requirements.txt ./zephyr/scripts/requirements.txt | |||
| # pip-compile --allow-unsafe --annotation-style=line --output-file=/home/runner/work/sdk-nrf-testing/sdk-nrf-testing/ncs/nrf/scripts/requirements-fixed.txt --strip-extras ./bootloader/mcuboot/scripts/requirements.txt ./nrf/scripts/requirements-ci.txt ./nrf/scripts/requirements-extra.txt ./nrf/scripts/requirements.txt ./zephyr/scripts/requirements.txt | |||
There was a problem hiding this comment.
can we avoid invoking pip-compile with the full path to the out file ?
Ref: --output-file=/home/runner/work/sdk-nrf-testing/sdk-nrf-testing/ncs/nrf/scripts/requirements-fixed.txt
Especially because it's unfortunate to simply have changes to a file simply because a github workflow uses a different path.
There was a problem hiding this comment.
I don't think the path will change in the future.
This change is only highlighted here as I used a locally generated file to trigger the pipeline.
Will check if it is possible to drop the full path and only use relative format
There was a problem hiding this comment.
if it's ok with Torsten, I propose we merge this as is (since the path is generated in a file that isn't in this PR)
and then look at printing a relative path when we 'backport/upmerge' this to sdk-nrf-next.
DatGizmo
force-pushed
the
pip-req-format-update
branch
from
f5433ef
to
df0b9bc
Compare
|
this is still needed right? take out of draft? |
DatGizmo
force-pushed
the
pip-req-format-update
branch
from
df0b9bc
to
dbf46cb
Compare
* The compile script output format was changed, updating requirements-fixed.txt to the new format Signed-off-by: Sebastian Wezel <sebastian.wezel@nordicsemi.no>
DatGizmo
force-pushed
the
pip-req-format-update
branch
from
dbf46cb
to
3da4b77
Compare
This is an automated commit from github workflow by NordicBuilder Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
This PR requires #12626 to be merged, and might need a rebase.