application: serial_lte_modem: Automatic LTE connection #12849

junqingzou · 2023-10-25T05:34:55Z

Move the lte auto-connect from SLM LwM2M client to full SLM scope.
Support lte auto-connnect by new Kconfig CONFIG_SLM_AUTO_CONNECT.
Default behavior is no automatic LTE connection, same as before.

When auto-connect is enabled, need to customize network-specific
PDN configuration in code. Default is Non-IP in NB-IoT for NIDD.

Impact on LwM2M client:
.Operation "auto_connect" is removed from LwM2M command.
.No more dynamic config of auto_connect (and auto_register).
.CONFIG_SLM_AUTO_CONNECT is enabled by default in overlay.

Change CONFIG_SLM_CUSTOMIZED to CONFIG_SLM_CUSTOMER_VERSION to
allow reporting customer version of SLM after customization.

Remove unused CONFIG_SLM_AT_MODE and CONFIG_SLM_SOCKET_RX_MAX.

junqingzou · 2023-10-25T05:35:40Z

DNM: not for NCS v2.5.0, no review needed as of now. Doc changes come later

NordicBuilder · 2023-10-25T05:35:54Z

Test specification

CI/Jenkins/NRF

Integration Platforms

CI/Jenkins/integration

Test Module	File based changes	Manually selected	West overwrite
test-fw-nrfconnect-nrf-iot_serial_lte_modem	X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

NordicBuilder · 2023-10-25T06:11:42Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

applications/serial_lte_modem/src/lwm2m_carrier/slm_at_carrier.c

tomi-font

Request review once ready for review.

tomi-font

It seems that lte_auto_connect() is not quite ready.

applications/serial_lte_modem/Kconfig

applications/serial_lte_modem/prj.conf

applications/serial_lte_modem/src/slm_at_commands.c

applications/serial_lte_modem/Kconfig

applications/serial_lte_modem/doc/slm_description.rst

applications/serial_lte_modem/prj.conf

applications/serial_lte_modem/src/main.c

tomi-font · 2023-11-10T14:49:04Z

Also, you are introducing different changes (auto-connect, custom version string) in a single commit whose title doesn't (and cannot) reflect that. I think it would be good to split it up.

junqingzou · 2023-11-13T02:04:16Z

Also, you are introducing different changes (auto-connect, custom version string) in a single commit whose title doesn't (and cannot) reflect that. I think it would be good to split it up.

Customer version string has direct relationship with different default network configuration from this PR. The version string change actually should have been introduced before, as in the market SLM is not always used out of box. Customers DO customize SLM to meet their own need, e.g. integrating soft sim, etc, which means they need version control as well. The customer version string is also required for APP FOTA (to update SLM). For example, current work with LwM2M Carrier requires a version that could reflect the update of lib_lwm2m_carrier.

junqingzou · 2023-11-13T08:18:56Z

CI seems to have failed due to TimeoutError: AT#XCARRIER="auto_connect","read" timed out waiting for OK

I can remove that part of the test case, so CI can pass. There is a question of whether this is used often enough without LWM2M that we should alter our current test cases to test the combination?

The auto-connect is not just for LwM2M over NIDD, but also for
.LwM2M over IP
.Non-LwM2M SLM client in LTE-M, NB-IoT even NIDD
Idea is to put all requried network configuiration in "slm_auto_connect.h".
What I tested (all my SIMs allow):
.LwM2M over NIDD
.Normal LTE-M requires APN and user authentication
.Normal NB-IoT requires APN and user authentication
.Normal LTE-M requires APN only

applications/serial_lte_modem/Kconfig

applications/serial_lte_modem/doc/Generic_AT_commands.rst

applications/serial_lte_modem/src/slm_at_commands.c

applications/serial_lte_modem/src/slm_net_cfg.h

applications/serial_lte_modem/src/main.c

applications/serial_lte_modem/src/slm_net_cfg.h

applications/serial_lte_modem/prj.conf

applications/serial_lte_modem/src/main.c

applications/serial_lte_modem/src/slm_auto_connect.h

applications/serial_lte_modem/src/main.c

applications/serial_lte_modem/Kconfig

applications/serial_lte_modem/doc/slm_description.rst

applications/serial_lte_modem/src/slm_auto_connect.h

tomi-font

Just a few bits to address left from my perspective (including some unaddressed previous comment of mine).

applications/serial_lte_modem/doc/slm_description.rst

applications/serial_lte_modem/Kconfig

applications/serial_lte_modem/src/slm_auto_connect.h

applications/serial_lte_modem/doc/slm_description.rst

applications/serial_lte_modem/src/main.c

applications/serial_lte_modem/doc/slm_description.rst

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

applications/serial_lte_modem/doc/slm_description.rst

kacperradoszewski

Other than a few nits, looks good to me

kacperradoszewski · 2023-11-15T07:38:01Z

applications/serial_lte_modem/src/main.c

+		int lte_preference;    /* 0 ~ 4 */
+		/* Refer to AT command manual of +CGDCONT and +CGAUTH for PDN configuration */
+		bool pdp_config;       /* PDP context definition required or not */
+		char *pdn_fam;         /* PDP type: "Non-IP"; ""IP", "IPV6", "IPV4V6", "Non-IP" */


Suggested change

char *pdn_fam; /* PDP type: "Non-IP"; ""IP", "IPV6", "IPV4V6", "Non-IP" */

char *pdn_fam; /* PDP type: "IP", "IPV6", "IPV4V6", "Non-IP" */

kacperradoszewski · 2023-11-15T07:39:03Z

applications/serial_lte_modem/src/slm_auto_connect.h

+0,        /* LTE preference */
+/* Network-specific default PDN configured by +CGDCONT and +CGAUTH (refer to AT command manual) */
+false,    /* PDP context definition required or not */
+"",       /* PDP type: ""IP", "IPV6", "IPV4V6", "Non-IP" */


Suggested change

"", /* PDP type: ""IP", "IPV6", "IPV4V6", "Non-IP" */

"", /* PDP type: "IP", "IPV6", "IPV4V6", "Non-IP" */

kacperradoszewski · 2023-11-15T07:44:17Z

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

+  * ``#XSLMVER`` AT command to report CONFIG_SLM_CUSTOMER_VERSION if it is defined
+
+* Removed:
+  * The ``CONFIG_SLM_CUSTOMIZED`` Kconfig option due it to no longer being used.


Suggested change

* The ``CONFIG_SLM_CUSTOMIZED`` Kconfig option due it to no longer being used.

* The ``CONFIG_SLM_CUSTOMIZED`` Kconfig option due to it to no longer being used.

That one's on me, and should actually be:

Suggested change

* The ``CONFIG_SLM_CUSTOMIZED`` Kconfig option due it to no longer being used.

* The ``CONFIG_SLM_CUSTOMIZED`` Kconfig option due to it no longer being used.

Ah, I almost got it right 😄

kacperradoszewski · 2023-11-15T07:44:49Z

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst


 * Updated:

  * ``#XMQTTCON`` AT command to exclude MQTT client ID from the parameter list.
+  * ``#XSLMVER`` AT command to report CONFIG_SLM_CUSTOMER_VERSION if it is defined


Suggested change

* ``#XSLMVER`` AT command to report CONFIG_SLM_CUSTOMER_VERSION if it is defined

* ``#XSLMVER`` AT command to report CONFIG_SLM_CUSTOMER_VERSION if it is defined.

Nice catch!

kacperradoszewski · 2023-11-15T07:47:52Z

applications/serial_lte_modem/src/main.c

 #if defined(CONFIG_SLM_CARRIER)
 #include "slm_at_carrier.h"
 #endif


Suggested change

#if defined(CONFIG_SLM_CARRIER)

#include "slm_at_carrier.h"

#endif

No longer needed I think

Yes as LwM2M not VIP any more

kacperradoszewski · 2023-11-15T07:48:21Z

applications/serial_lte_modem/doc/slm_description.rst

+      0,        /* LTE preference */
+      /* Network-specific default PDN configured by +CGDCONT and +CGAUTH (refer to AT command manual) */
+      true,     /* PDP context definition required or not */
+      "Non-IP", /* PDP type: ""IP", "IPV6", "IPV4V6", "Non-IP" */


Suggested change

"Non-IP", /* PDP type: ""IP", "IPV6", "IPV4V6", "Non-IP" */

"Non-IP", /* PDP type: "IP", "IPV6", "IPV4V6", "Non-IP" */

applications/serial_lte_modem/doc/slm_description.rst

Move the lte auto-connect from SLM LwM2M client to full SLM scope. Support lte auto-connnect by new Kconfig CONFIG_SLM_AUTO_CONNECT. Default behavior is no automatic LTE connection, same as before. When auto-connect is enabled, need to customize network-specific PDN configuration in code. Default is Non-IP in NB-IoT for NIDD. Impact on LwM2M client: .Operation "auto_connect" is removed from LwM2M command. .No more dynamic config of auto_connect (and auto_register). .CONFIG_SLM_AUTO_CONNECT is enabled by default in overlay. Change CONFIG_SLM_CUSTOMIZED to CONFIG_SLM_CUSTOMER_VERSION to allow reporting customer version of SLM after customization. Remove unused CONFIG_SLM_AT_MODE and CONFIG_SLM_SOCKET_RX_MAX. Signed-off-by: Jun Qing Zou <jun.qing.zou@nordicsemi.no>

junqingzou · 2023-11-15T12:12:44Z

Thanks for all the comments.
I'm asking for merging now.

junqingzou added the DNM label Oct 25, 2023

junqingzou requested a review from kacperradoszewski October 25, 2023 05:34

junqingzou requested review from tejlmand, SeppoTakalo, MarkusLassila, rlubos and tomi-font as code owners October 25, 2023 05:34

github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 25, 2023

MarkusLassila requested a review from mgolu October 25, 2023 06:11

MarkusLassila reviewed Oct 25, 2023

View reviewed changes

applications/serial_lte_modem/src/lwm2m_carrier/slm_at_carrier.c Show resolved Hide resolved

kacperradoszewski approved these changes Nov 8, 2023

View reviewed changes

tomi-font requested changes Nov 8, 2023

View reviewed changes

junqingzou force-pushed the pr_slm_auto_connect branch from 18b7bd2 to 6f09612 Compare November 10, 2023 01:45

junqingzou requested a review from carlescufi as a code owner November 10, 2023 01:45

github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 10, 2023

junqingzou added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. and removed DNM labels Nov 10, 2023

junqingzou requested review from kacperradoszewski, tomi-font and MarkusLassila November 10, 2023 01:46

junqingzou force-pushed the pr_slm_auto_connect branch from 6f09612 to f20fbae Compare November 10, 2023 02:20

github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 10, 2023

tomi-font requested changes Nov 10, 2023

View reviewed changes

junqingzou force-pushed the pr_slm_auto_connect branch from f20fbae to e7b8e4c Compare November 13, 2023 02:06

tomi-font requested changes Nov 13, 2023

View reviewed changes

junqingzou force-pushed the pr_slm_auto_connect branch from 5ce6895 to 22c0ee1 Compare November 13, 2023 09:57

tomi-font requested changes Nov 13, 2023

View reviewed changes

applications/serial_lte_modem/prj.conf Outdated Show resolved Hide resolved

applications/serial_lte_modem/src/main.c Outdated Show resolved Hide resolved

applications/serial_lte_modem/src/main.c Outdated Show resolved Hide resolved

MarkusLassila requested changes Nov 13, 2023

View reviewed changes

MarkusLassila reviewed Nov 13, 2023

View reviewed changes

applications/serial_lte_modem/Kconfig Outdated Show resolved Hide resolved

kacperradoszewski reviewed Nov 13, 2023

View reviewed changes

applications/serial_lte_modem/doc/slm_description.rst Outdated Show resolved Hide resolved

junqingzou force-pushed the pr_slm_auto_connect branch from 22c0ee1 to 9bf612f Compare November 14, 2023 02:15

MarkusLassila requested changes Nov 14, 2023

View reviewed changes

applications/serial_lte_modem/src/slm_auto_connect.h Outdated Show resolved Hide resolved

tomi-font requested changes Nov 14, 2023

View reviewed changes

applications/serial_lte_modem/doc/slm_description.rst Outdated Show resolved Hide resolved

applications/serial_lte_modem/Kconfig Outdated Show resolved Hide resolved

junqingzou force-pushed the pr_slm_auto_connect branch from 9bf612f to 7619ec2 Compare November 14, 2023 07:53

MarkusLassila approved these changes Nov 14, 2023

View reviewed changes

tomi-font requested changes Nov 14, 2023

View reviewed changes

applications/serial_lte_modem/src/slm_auto_connect.h Outdated Show resolved Hide resolved

applications/serial_lte_modem/src/slm_auto_connect.h Outdated Show resolved Hide resolved

applications/serial_lte_modem/doc/slm_description.rst Outdated Show resolved Hide resolved

tomi-font requested a review from wiba-nordic November 14, 2023 11:14

kacperradoszewski reviewed Nov 14, 2023

View reviewed changes

applications/serial_lte_modem/src/main.c Outdated Show resolved Hide resolved

wiba-nordic requested changes Nov 14, 2023

View reviewed changes

junqingzou force-pushed the pr_slm_auto_connect branch 2 times, most recently from d5e91cc to 0fd2d8b Compare November 15, 2023 01:21

wiba-nordic requested changes Nov 15, 2023

View reviewed changes

junqingzou force-pushed the pr_slm_auto_connect branch from 0fd2d8b to 803c195 Compare November 15, 2023 07:20

wiba-nordic approved these changes Nov 15, 2023

View reviewed changes

kacperradoszewski reviewed Nov 15, 2023

View reviewed changes

tomi-font requested changes Nov 15, 2023

View reviewed changes

applications/serial_lte_modem/doc/slm_description.rst Outdated Show resolved Hide resolved

junqingzou force-pushed the pr_slm_auto_connect branch from 803c195 to 8d42fab Compare November 15, 2023 09:06

tomi-font self-requested a review November 15, 2023 09:09

tomi-font approved these changes Nov 15, 2023

View reviewed changes

kacperradoszewski approved these changes Nov 15, 2023

View reviewed changes

nordicjm merged commit 710acdb into nrfconnect:main Nov 15, 2023
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

application: serial_lte_modem: Automatic LTE connection #12849

application: serial_lte_modem: Automatic LTE connection #12849

junqingzou commented Oct 25, 2023 •

edited

Loading

junqingzou commented Oct 25, 2023 •

edited

Loading

NordicBuilder commented Oct 25, 2023 •

edited

Loading

NordicBuilder commented Oct 25, 2023

tomi-font left a comment

tomi-font left a comment

tomi-font commented Nov 10, 2023 •

edited

Loading

junqingzou commented Nov 13, 2023

junqingzou commented Nov 13, 2023

tomi-font left a comment •

edited

Loading

kacperradoszewski left a comment

kacperradoszewski Nov 15, 2023

kacperradoszewski Nov 15, 2023

kacperradoszewski Nov 15, 2023

wiba-nordic Nov 15, 2023

kacperradoszewski Nov 15, 2023

kacperradoszewski Nov 15, 2023

wiba-nordic Nov 15, 2023

kacperradoszewski Nov 15, 2023

junqingzou Nov 15, 2023

kacperradoszewski Nov 15, 2023

junqingzou commented Nov 15, 2023

	char pdn_fam; / PDP type: "Non-IP"; ""IP", "IPV6", "IPV4V6", "Non-IP" */
	char pdn_fam; / PDP type: "IP", "IPV6", "IPV4V6", "Non-IP" */

	"", /* PDP type: ""IP", "IPV6", "IPV4V6", "Non-IP" */
	"", /* PDP type: "IP", "IPV6", "IPV4V6", "Non-IP" */

	* The ``CONFIG_SLM_CUSTOMIZED`` Kconfig option due it to no longer being used.
	* The ``CONFIG_SLM_CUSTOMIZED`` Kconfig option due to it to no longer being used.

	* ``#XSLMVER`` AT command to report CONFIG_SLM_CUSTOMER_VERSION if it is defined
	* ``#XSLMVER`` AT command to report CONFIG_SLM_CUSTOMER_VERSION if it is defined.

	#if defined(CONFIG_SLM_CARRIER)
	#include "slm_at_carrier.h"
	#endif

	"Non-IP", /* PDP type: ""IP", "IPV6", "IPV4V6", "Non-IP" */
	"Non-IP", /* PDP type: "IP", "IPV6", "IPV4V6", "Non-IP" */

application: serial_lte_modem: Automatic LTE connection #12849

application: serial_lte_modem: Automatic LTE connection #12849

Conversation

junqingzou commented Oct 25, 2023 • edited Loading

junqingzou commented Oct 25, 2023 • edited Loading

NordicBuilder commented Oct 25, 2023 • edited Loading

Test specification

NordicBuilder commented Oct 25, 2023

tomi-font left a comment

Choose a reason for hiding this comment

tomi-font left a comment

Choose a reason for hiding this comment

tomi-font commented Nov 10, 2023 • edited Loading

junqingzou commented Nov 13, 2023

junqingzou commented Nov 13, 2023

tomi-font left a comment • edited Loading

Choose a reason for hiding this comment

kacperradoszewski left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

junqingzou commented Nov 15, 2023

junqingzou commented Oct 25, 2023 •

edited

Loading

junqingzou commented Oct 25, 2023 •

edited

Loading

NordicBuilder commented Oct 25, 2023 •

edited

Loading

tomi-font commented Nov 10, 2023 •

edited

Loading

tomi-font left a comment •

edited

Loading