Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: pmic: npm1300_fuel_gauge: Floating point printf support #13622

Conversation

aasinclair
Copy link
Contributor

Explicitly enabled support for floating point in printf.

Since the change of default library to picolib, this need to be explicit.

@aasinclair aasinclair requested a review from a team as a code owner January 16, 2024 11:02
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 16, 2024
@aasinclair
Copy link
Contributor Author

Related upstream PR: zephyrproject-rtos/zephyr#63332

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 16, 2024

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@aasinclair aasinclair force-pushed the sample-fuel-gauge-floating-point-printf-broken branch from a1b5ec8 to 891e2da Compare January 16, 2024 11:06
@aasinclair aasinclair added the bugfix Fixes a known bug label Jan 16, 2024
Explicitly enabled support for floating point in printf.

Since the change of default library to picolib, this need to be
explicit.  It was previously included implicitly by newlib.

Signed-off-by: Andy Sinclair <andy.sinclair@nordicsemi.no>
@aasinclair aasinclair force-pushed the sample-fuel-gauge-floating-point-printf-broken branch from 891e2da to 75230f4 Compare January 16, 2024 11:29
Copy link
Contributor

@nordic-piks nordic-piks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked at HW, working fine.

@aasinclair aasinclair self-assigned this Jan 16, 2024
@aasinclair aasinclair removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 16, 2024
@shanthanordic shanthanordic removed the request for review from a team January 17, 2024 08:00
@nordicjm nordicjm merged commit 556c4f7 into nrfconnect:main Jan 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants