Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: redistributing: use latest tag for Golioth #15812

Merged

Conversation

szczys
Copy link
Contributor

@szczys szczys commented Jun 6, 2024

Updated the links to the Golioth Zephyr SDK to use the latest v0.13.1 release.

This is a new PR that implements the same changes that were approved in #12551 (the difference is the version numbers have been updated to latest).

That PR was approved more than once but never merged. If there is anything I can do to help get this across the finish line, please let me know.

Approvers of the previous PR:

Updated the links to the Golioth Zephyr SDK to use the latest v0.13.1
release.

Signed-off-by: Mike Szczys <mike@golioth.io>
@szczys szczys requested a review from carlescufi as a code owner June 6, 2024 21:34
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jun 6, 2024
@NordicBuilder
Copy link
Contributor

Thank you for your contribution!
It seems you are not a member of the nrfconnect GitHub organization. External contributions are handled as follows:
Large contributions, affecting multiple subsystems for example, may be rejected if they are complex, may introduce regressions due to lack of test coverage, or if they are not consistent with the architecture of nRF Connect SDK.
PRs will be run in our continuous integration (CI) test system.
If CI passes, PRs will be tagged for review and merged on successful completion of review. You may be asked to make some modifications to your contribution during review.
If CI fails, PRs may be rejected or may be tagged for review and rework.
PRs that become outdated due to other changes in the repository may be rejected or rework requested.
External contributions will be prioritized for review based on the relevance to current development efforts in nRF Connect SDK. Bug fix PRs will be prioritized.
You may raise issues or ask for help from our Technical Support team by visiting https://devzone.nordicsemi.com/.

Note: This comment is automatically posted and updated by the Contribs GitHub Action.

@NordicBuilder NordicBuilder added the external External contribution label Jun 6, 2024
@wiba-nordic wiba-nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jun 7, 2024
@lemrey lemrey added this to the 2.7.0 milestone Jun 7, 2024
@lemrey lemrey requested a review from divipillai June 7, 2024 13:51
Copy link
Contributor

@lemrey lemrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I let CI run and added the milestone.

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@anangl
Copy link
Contributor

anangl commented Jun 12, 2024

This is a documentation change only, it does not need a CI run (the documentation build was successful).

@anangl anangl merged commit 0f72158 into nrfconnect:main Jun 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval. external External contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants