Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applications: nrf5340_audio: Audio module improvements #16658

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

gWacey
Copy link
Contributor

@gWacey gWacey commented Jul 29, 2024

Corrections from use, additional testing and fake function updates.

@gWacey gWacey requested review from a team, anangl and rlubos as code owners July 29, 2024 15:21
@gWacey gWacey requested review from koffes, andvib, rick1082 and alexsven and removed request for a team July 29, 2024 15:21
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 29, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 29, 2024

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

include/audio_module/audio_module.h Outdated Show resolved Hide resolved
subsys/audio_module/audio_module.c Outdated Show resolved Hide resolved
subsys/audio_module/audio_module.c Outdated Show resolved Hide resolved
subsys/audio_module/audio_module.c Show resolved Hide resolved
tests/subsys/audio_module/prj.conf Outdated Show resolved Hide resolved
tests/subsys/audio_module/src/audio_module_test_common.c Outdated Show resolved Hide resolved
tests/subsys/audio_module/src/audio_module_test_common.c Outdated Show resolved Hide resolved
tests/subsys/audio_module/src/fakes.c Outdated Show resolved Hide resolved
tests/subsys/audio_module/src/functional_test.c Outdated Show resolved Hide resolved
Copy link
Contributor

@andvib andvib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only minor comments - mostly some missing return checks

subsys/audio_module/CMakeLists.txt Outdated Show resolved Hide resolved
subsys/audio_module/CMakeLists.txt Outdated Show resolved Hide resolved
subsys/audio_module/audio_module.c Outdated Show resolved Hide resolved
tests/subsys/audio_module/src/fakes.c Show resolved Hide resolved
tests/subsys/audio_module/src/fakes.c Show resolved Hide resolved
tests/subsys/audio_module/src/fakes.c Outdated Show resolved Hide resolved
tests/subsys/audio_module/src/fakes.c Outdated Show resolved Hide resolved
tests/subsys/audio_module/src/fakes.c Outdated Show resolved Hide resolved
tests/subsys/audio_module/src/functional_test.c Outdated Show resolved Hide resolved
@gWacey gWacey force-pushed the Audio-Module-Updates branch 4 times, most recently from 3b2ccef to a09e6e5 Compare August 8, 2024 13:15
@koffes koffes self-requested a review August 21, 2024 11:42
Copy link
Contributor

@koffes koffes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-requested a review from myself too soon :)

@gWacey gWacey force-pushed the Audio-Module-Updates branch 2 times, most recently from b55bf56 to d04e52a Compare August 27, 2024 13:43
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 27, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 16

Inputs:

Sources:

sdk-nrf: PR head: ae1e1712e26ebf4708815df8f29a3979d9a5b0ee

more details

sdk-nrf:

PR head: ae1e1712e26ebf4708815df8f29a3979d9a5b0ee
merge base: ea2da455203ce6876392d9e4fcc78b1ed537de53
target head (main): b19a7fb5e969027a064b2bc72cd5545d99f14377
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (16)
include
│  ├── audio_defines.h
│  ├── audio_module
│  │  │ audio_module.h
│  │ data_fifo.h
lib
│  ├── data_fifo
│  │  │ data_fifo.c
subsys
│  ├── audio_module
│  │  ├── CMakeLists.txt
│  │  ├── Kconfig
│  │  │ audio_module.c
tests
│  ├── subsys
│  │  ├── audio_module
│  │  │  ├── CMakeLists.txt
│  │  │  ├── src
│  │  │  │  ├── audio_module_test_common.c
│  │  │  │  ├── audio_module_test_common.h
│  │  │  │  ├── audio_module_test_fakes.c
│  │  │  │  ├── audio_module_test_fakes.h
│  │  │  │  ├── bad_param_test.c
│  │  │  │  ├── functional_test.c
│  │  │  │  │ main.c
│  │  │  │ testcase.yaml

Outputs:

Toolchain

Version: 9338b70c26
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:9338b70c26_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 38
  • ✅ Integration tests
    • ✅ test-sdk-audio
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

@gWacey gWacey force-pushed the Audio-Module-Updates branch 2 times, most recently from 2fb6792 to efc2529 Compare August 28, 2024 12:01
@gWacey gWacey requested review from koffes and andvib August 28, 2024 12:02
@gWacey gWacey force-pushed the Audio-Module-Updates branch 2 times, most recently from b954337 to c46cb12 Compare August 28, 2024 12:25
@gWacey gWacey requested a review from andvib August 28, 2024 19:21
@gWacey gWacey force-pushed the Audio-Module-Updates branch 3 times, most recently from bddbb9c to a948038 Compare August 29, 2024 07:33
Copy link
Contributor

@koffes koffes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice :) A couple of topics to discuss.

    Corrections from use, additional testing and fake function updates.

Signed-off-by: Graham Wacey <graham.wacey@nordicsemi.no>
@nordicjm nordicjm merged commit fbd273e into nrfconnect:main Sep 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants