-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
applications: nrf5340_audio: Audio module improvements #16658
Conversation
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only minor comments - mostly some missing return checks
3b2ccef
to
a09e6e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-requested a review from myself too soon :)
b55bf56
to
d04e52a
Compare
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: ae1e1712e26ebf4708815df8f29a3979d9a5b0ee more detailssdk-nrf:
Github labels
List of changed files detected by CI (16)
Outputs:ToolchainVersion: 9338b70c26 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
2fb6792
to
efc2529
Compare
b954337
to
c46cb12
Compare
bddbb9c
to
a948038
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice :) A couple of topics to discuss.
a948038
to
54f6ba6
Compare
Corrections from use, additional testing and fake function updates. Signed-off-by: Graham Wacey <graham.wacey@nordicsemi.no>
54f6ba6
to
ae1e171
Compare
Corrections from use, additional testing and fake function updates.