Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

west.yml: Update zephyr to bring in zcbor 0.9.0 #16974

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

oyvindronningstad
Copy link
Contributor

Updated from 0.8.2

@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Aug 22, 2024
@oyvindronningstad oyvindronningstad marked this pull request as draft August 22, 2024 11:09
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 22, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@4322f51 (main) nrfconnect/sdk-zephyr#1966 nrfconnect/sdk-zephyr#1966/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 22, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 20

Inputs:

Sources:

sdk-nrf: PR head: 3725b90aeb8eea427a0228bed1b90caaf5360891
zcbor: PR head: 47f34dd7f5284e8750b5a715dee7f77c6c5bdc3f
zephyr: PR head: 789798e140f61e3d6874e89d486bd0b88e380b69

more details

sdk-nrf:

PR head: 3725b90aeb8eea427a0228bed1b90caaf5360891
merge base: 1a56b7a984c267e9b598e2882fb663b96282ac2b
target head (main): 1a56b7a984c267e9b598e2882fb663b96282ac2b
Diff

zcbor:

PR head: 47f34dd7f5284e8750b5a715dee7f77c6c5bdc3f
merge base: b85a5508d473ef6d301d92eae2d721369a5a7665
Diff

zephyr:

PR head: 789798e140f61e3d6874e89d486bd0b88e380b69
merge base: 4322f5169f4c0f24e3712de061a2fec5a29098a7
target head (main): 4322f5169f4c0f24e3712de061a2fec5a29098a7
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (123)
doc
│  ├── nrf
│  │  ├── links.txt
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
modules
│  ├── lib
│  │  ├── zcbor
│  │  │  ├── .github
│  │  │  │  ├── actions
│  │  │  │  │  ├── prepare_and_run_tests
│  │  │  │  │  │  │ action.yaml
│  │  │  │  ├── workflows
│  │  │  │  │  │ run-tests.yaml
│  │  │  ├── .gitignore
│  │  │  ├── ARCHITECTURE.md
│  │  │  ├── MIGRATION_GUIDE.md
│  │  │  ├── README.md
│  │  │  ├── RELEASE_NOTES.md
│  │  │  ├── include
│  │  │  │  ├── zcbor_common.h
│  │  │  │  ├── zcbor_decode.h
│  │  │  │  ├── zcbor_encode.h
│  │  │  │  ├── zcbor_print.h
│  │  │  │  │ zcbor_tags.h
│  │  │  ├── samples
│  │  │  │  ├── pet
│  │  │  │  │  ├── include
│  │  │  │  │  │  ├── pet_decode.h
│  │  │  │  │  │  ├── pet_encode.h
│  │  │  │  │  │  │ pet_types.h
│  │  │  │  │  ├── pet.cmake
│  │  │  │  │  ├── src
│  │  │  │  │  │  ├── pet_decode.c
│  │  │  │  │  │  │ pet_encode.c
│  │  │  ├── scripts
│  │  │  │  ├── requirements-test.txt
│  │  │  │  │ update_version.py
│  │  │  ├── src
│  │  │  │  ├── zcbor_common.c
│  │  │  │  ├── zcbor_decode.c
│  │  │  │  ├── zcbor_encode.c
│  │  │  │  │ zcbor_print.c
│  │  │  ├── tests
│  │  │  │  ├── be_test.sh
│  │  │  │  ├── cases
│  │  │  │  │  │ corner_cases.cddl
│  │  │  │  ├── cmake
│  │  │  │  │  │ test_template.cmake
│  │  │  │  ├── decode
│  │  │  │  │  ├── test1_suit_old_formats
│  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  │  ├── test2_suit
│  │  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  │  ├── test3_simple
│  │  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  │  ├── test5_corner_cases
│  │  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ main.c
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  │  ├── test7_suit9_simple
│  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  │  ├── test8_suit12
│  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  │  ├── test9_manifest14
│  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  ├── encode
│  │  │  │  │  ├── test1_suit
│  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  │  ├── test2_simple
│  │  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │  ├── file_header_copyright.txt
│  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ main.c
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  │  ├── test3_corner_cases
│  │  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ main.c
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  │  ├── test4_senml
│  │  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ main.c
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  ├── include
│  │  │  │  │  │ common_test.h
│  │  │  │  ├── scripts
│  │  │  │  │  ├── test_versions.py
│  │  │  │  │  │ test_zcbor.py
│  │  │  │  ├── test.sh
│  │  │  │  ├── unit
│  │  │  │  │  ├── test1_unit_tests
│  │  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ main.c
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  │  ├── test2_cpp
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  │  ├── test3_float16
│  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  │ testcase.yaml
│  │  │  ├── zcbor
│  │  │  │  ├── VERSION
│  │  │  │  │ zcbor.py
subsys
│  ├── dfu
│  │  ├── fmfu_fdev
│  │  │  ├── include
│  │  │  │  ├── modem_update_decode.h
│  │  │  │  │ modem_update_types.h
│  │  │  ├── src
│  │  │  │  │ modem_update_decode.c
│  ├── sdfw_services
│  │  ├── services
│  │  │  ├── echo
│  │  │  │  ├── zcbor_generated
│  │  │  │  │  ├── echo_service_decode.c
│  │  │  │  │  ├── echo_service_decode.h
│  │  │  │  │  ├── echo_service_encode.c
│  │  │  │  │  ├── echo_service_encode.h
│  │  │  │  │  │ echo_service_types.h
│  │  │  ├── enc_fw
│  │  │  │  ├── zcbor_generated
│  │  │  │  │  ├── enc_fw_service_decode.c
│  │  │  │  │  ├── enc_fw_service_decode.h
│  │  │  │  │  ├── enc_fw_service_encode.c
│  │  │  │  │  ├── enc_fw_service_encode.h
│  │  │  │  │  │ enc_fw_service_types.h
│  │  │  ├── extmem
│  │  │  │  ├── zcbor_generated
│  │  │  │  │  ├── extmem_service_decode.c
│  │  │  │  │  ├── extmem_service_decode.h
│  │  │  │  │  ├── extmem_service_encode.c
│  │  │  │  │  ├── extmem_service_encode.h
│  │  │  │  │  │ extmem_service_types.h
│  │  │  ├── psa_crypto
│  │  │  │  ├── zcbor_generated
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── psa_crypto_service_decode.c
│  │  │  │  │  ├── psa_crypto_service_decode.h
│  │  │  │  │  ├── psa_crypto_service_encode.c
│  │  │  │  │  ├── psa_crypto_service_encode.h
│  │  │  │  │  │ psa_crypto_service_types.h
│  │  │  ├── reset_evt
│  │  │  │  ├── zcbor_generated
│  │  │  │  │  ├── reset_evt_service_decode.c
│  │  │  │  │  ├── reset_evt_service_decode.h
│  │  │  │  │  ├── reset_evt_service_encode.c
│  │  │  │  │  ├── reset_evt_service_encode.h
│  │  │  │  │  │ reset_evt_service_types.h
│  │  │  ├── sdfw_update
│  │  │  │  ├── zcbor_generated
│  │  │  │  │  ├── sdfw_update_service_decode.c
│  │  │  │  │  ├── sdfw_update_service_decode.h
│  │  │  │  │  ├── sdfw_update_service_encode.c
│  │  │  │  │  ├── sdfw_update_service_encode.h
│  │  │  │  │  │ sdfw_update_service_types.h
│  │  │  ├── suit_service
│  │  │  │  ├── zcbor_generated
│  │  │  │  │  ├── suit_service_decode.c
│  │  │  │  │  ├── suit_service_decode.h
│  │  │  │  │  ├── suit_service_encode.c
│  │  │  │  │  ├── suit_service_encode.h
│  │  │  │  │  │ suit_service_types.h
west.yml
zephyr
│  ├── subsys
│  │  ├── net
│  │  │  ├── lib
│  │  │  │  ├── lwm2m
│  │  │  │  │  ├── lwm2m_senml_cbor.patch
│  │  │  │  │  ├── lwm2m_senml_cbor_decode.c
│  │  │  │  │  ├── lwm2m_senml_cbor_decode.h
│  │  │  │  │  ├── lwm2m_senml_cbor_encode.c
│  │  │  │  │  ├── lwm2m_senml_cbor_encode.h
│  │  │  │  │  ├── lwm2m_senml_cbor_regenerate.sh
│  │  │  │  │  │ lwm2m_senml_cbor_types.h
│  │ west.yml

Outputs:

Toolchain

Version: 9583beca34
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:9583beca34_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
  • ❌ Integration tests
    • ✅ test-sdk-audio
    • ✅ desktop52_verification
    • ✅ test-fw-nrfconnect-boot
    • ✅ test-fw-nrfconnect-apps
    • ✅ test_ble_nrf_config
    • ❌ test-fw-nrfconnect-ble_mesh
    • ✅ test-fw-nrfconnect-ble_samples
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-nfc
    • ❌ test-fw-nrfconnect-nrf-iot_cloud
    • ❌ test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • ❌ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ❌ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ❌ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_lwm2m
    • ✅ doc-internal
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-fw-nrfconnect-nrf_crypto
    • ✅ test-fw-nrfconnect-proprietary_esb
    • ✅ test-fw-nrfconnect-rpc
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-fw-nrfconnect-tfm
    • ✅ test-fw-nrfconnect-thread
    • ✅ test-fw-nrfconnect-zigbee
    • ✅ test-sdk-find-my
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ✅ test-fw-nrfconnect-nrf-iot_positioning
    • ✅ test-sdk-sidewalk
    • ✅ test-sdk-wifi
    • ✅ test-low-level
    • ❌ test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • ✅ test-sdk-pmic-samples
    • ✅ test-sdk-mcuboot
    • ✅ test-sdk-dfu
    • ✅ test-fw-nrfconnect-ps
    • ⚠️ test-sdk-dfu

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@oyvindronningstad oyvindronningstad force-pushed the zcbor-0.9.0 branch 2 times, most recently from ec7d9c1 to bcec5eb Compare August 29, 2024 11:00
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Aug 29, 2024
@oyvindronningstad oyvindronningstad marked this pull request as ready for review September 4, 2024 12:53
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 10, 2024

Memory footprint analysis revealed the following potential issues

applications.nrf_desktop.zdebug.uart[nrf54h20dk/nrf54h20/cpuapp]: ROM size increased by 828[B] in comparison to the main[9c7c28c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf54h20dk/nrf54h20/cpuapp]: ROM size increased by 668[B] in comparison to the main[9c7c28c] branch. - link (cc: @MarekPieta)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-16974/20)

Comment on lines 892 to 916
sdfw
----

* sdfw_services: Regenerated generated code files using zcbor 0.9.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @FrancescoSer , do we have these libraries documented somewhere?

Updated from 0.8.2

Signed-off-by: Øyvind Rønningstad <oyvind.ronningstad@nordicsemi.no>
Using zcbor 0.9.0

Signed-off-by: Øyvind Rønningstad <oyvind.ronningstad@nordicsemi.no>
Using zcbor 0.9.0

Signed-off-by: Øyvind Rønningstad <oyvind.ronningstad@nordicsemi.no>
@oyvindronningstad
Copy link
Contributor Author

@greg-fer Thanks for the review, all comments adressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM doc-required PR must not be merged without tech writer approval. manifest manifest-zephyr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants