v2.5: drivers: wifi: Add PS exit strategy option #17003
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajayparida
requested review from
udaynordic,
srkanordic,
krish2718,
sachinthegreen,
rado17 and
rlubos
as code owners
github-actions
bot
added
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
krish2718
reviewed
Aug 26, 2024
sachinthegreen
requested changes
Aug 26, 2024
drivers/wifi/nrf700x/osal/fw_if/umac_if/inc/fw/host_rpu_sys_if.h
Outdated
Show resolved
Hide resolved
drivers/wifi/nrf700x/osal/fw_if/umac_if/inc/fw/host_rpu_sys_if.h
Outdated
Show resolved
Hide resolved
|
@ajayparida this feature is already part of main, please cherry-pick that to maintain same naming across. |
ajayparida
force-pushed
the
dynamic_ps_data_retrieval_2.5
branch
4 times, most recently
from
33191af
to
52dc523
Compare
ajayparida
requested review from
jukkar,
carlescufi and
tejlmand
as code owners
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
krish2718
approved these changes
Aug 27, 2024
karun2796
force-pushed
the
dynamic_ps_data_retrieval_2.5
branch
2 times, most recently
from
7d355d4
to
a9ae3d1
Compare
sachinthegreen
approved these changes
Aug 28, 2024
krish2718
force-pushed
the
dynamic_ps_data_retrieval_2.5
branch
from
a9ae3d1
to
35d20e8
Compare
ajayparida
force-pushed
the
dynamic_ps_data_retrieval_2.5
branch
from
35d20e8
to
a7d5558
Compare
ajayparida
force-pushed
the
dynamic_ps_data_retrieval_2.5
branch
3 times, most recently
from
0b724bb
to
95f81de
Compare
krish2718
force-pushed
the
dynamic_ps_data_retrieval_2.5
branch
4 times, most recently
from
8f9c24c
to
454d4b1
Compare
udaynordic
approved these changes
Aug 29, 2024
krish2718
changed the title
ajayparida
commented
Sep 3, 2024
Pull Wi-Fi management APIs for PS exit strategy configuration support. Signed-off-by: Ajay Parida <ajay.parida@nordicsemi.no> Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Dynamically set power save exit strategy runtime configuration that allows to switch b/w stratgies depending on conserving power and low-latency traffic download. Signed-off-by: Ajay Parida <ajay.parida@nordicsemi.no> Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
This helps in fixing recovery issues in case of heavy management traffic. Signed-off-by: Ajay Parida <ajay.parida@nordicsemi.no>
UMAC:
[SHEL-3044]: Run time API support to enable QOS null frame
based power save.
Signed-off-by: Karun Kumar Eagalapati <karun.kumar@nordicsemi.no>
The logic in the firmware is about exiting power save, the data retrieval itself is pretty standardized. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
UMAC:
[SHEL-3044]: Run time API support to enable QOS null frame
based power save.
Signed-off-by: Srinivasaraju Chintalapati <srinivasaraju.chintalapati@nordicsemi.no>
krish2718
force-pushed
the
dynamic_ps_data_retrieval_2.5
branch
from
454d4b1
to
58acea4
Compare
karun2796
force-pushed
the
dynamic_ps_data_retrieval_2.5
branch
from
58acea4
to
9ef1889
Compare
krish2718
force-pushed
the
dynamic_ps_data_retrieval_2.5
branch
2 times, most recently
from
9e38a2b
to
8a2d7d3
Compare
In some scenarios like reading WDOG status, it was observed that multiple retries are needed for the (Q)SPI read to be successful, so, add a retry support. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
It was assumed that RPU would stay awake while servicing an interrupt, but in few scenarios we had seen RPU entering sleep with a pending interrupt, so, independent of the state (IRQ or not), wakeup RPU if its asleep. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Ideally we should be using Zephyr spinlock APIs but that requires changes to shim API, so, for this maintenance release just replace with mutex to keep the context same and no API changes. This solves the locking issue that we see when control and data path are excited concurrently due to locking semantics of semaphores, the issue is not root caused but mutex enforce strict locking semantics for multiple threads and solve the issue. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
force-pushed
the
dynamic_ps_data_retrieval_2.5
branch
from
1e7c1d1
to
6ed11d6
Compare
*[SHEL-2694] : Power save enabled behavior with wmm mode. *Checking IRQ status before entering sleep mode upon receiving the sleep event from LMAC. Signed-off-by: Karun Kumar Eagalapati <karun.kumar@nordicsemi.no>
karun2796
force-pushed
the
dynamic_ps_data_retrieval_2.5
branch
from
69a233e
to
e2dd139
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamically set power save data retrieval mechanism.