Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Documentation edits for 2.7.99-cs1 release #17015

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

FrancescoSer
Copy link
Contributor

@FrancescoSer FrancescoSer commented Aug 26, 2024

Added firmware bundle compatibility table.
Updated nRF54H20 GS guide.
Added initial power management documentation.
Added initial clock control documentation

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Aug 26, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 26, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 22

Inputs:

Sources:

sdk-nrf: PR head: 8f816f4e70588b67d28891077a5681f223c31829

more details

sdk-nrf:

PR head: 8f816f4e70588b67d28891077a5681f223c31829
merge base: f7b59d26db4cc55c6936a0a88f3daa7e0b7b2085
target head (main): 2e9c82cc67f61bebcd5feaff24e4a807da028389> Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (10)
doc
│  ├── nrf
│  │  ├── app_dev
│  │  │  ├── device_guides
│  │  │  │  ├── nrf54h.rst
│  │  │  │  ├── working_with_nrf
│  │  │  │  │  ├── nrf54h
│  │  │  │  │  │  ├── ug_nrf54h20_architecture.rst
│  │  │  │  │  │  ├── ug_nrf54h20_architecture_clockman.rst
│  │  │  │  │  │  ├── ug_nrf54h20_architecture_pm.rst
│  │  │  │  │  │  │ ug_nrf54h20_gs.rst
│  │  ├── links.txt
│  │  ├── releases_and_maturity
│  │  │  ├── migration
│  │  │  │  ├── migration_guide_nRF54H20_cs_to_2_7.rst
│  │  │  │  │ migration_guide_nRF54H20_cs_to_2_7_99-cs1.rst
│  │  ├── samples
│  │  │  │ other.rst
tests
│  ├── benchmarks
│  │  ├── multicore
│  │  │  ├── idle
│  │  │  │  │ README.rst

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
    • ◻️ test-low-level
Disable integration tests
    • desktop52_verification
    • doc-internal
    • latest/ble/nrf/test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@FrancescoSer FrancescoSer force-pushed the 54Hprerelease_docedits branch 4 times, most recently from 408d986 to d073dcc Compare August 28, 2024 14:37
@FrancescoSer FrancescoSer added this to the 2.7.99-cs1 milestone Aug 28, 2024
@FrancescoSer FrancescoSer requested review from annwoj and removed request for annwoj August 28, 2024 14:40
@FrancescoSer FrancescoSer marked this pull request as ready for review August 28, 2024 15:34
doc/nrf/samples/other.rst Outdated Show resolved Hide resolved
Active
======

*Active* is the power state in which the CPU is actively processing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the power states be made italic. I haven't see these mentioned as Italic in other docs.

Copy link
Contributor Author

@FrancescoSer FrancescoSer Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not highlighting long power states name like "Local suspend to Ram" might render sentences containing these quite difficult to read. They don't have to be necessarily in italics, but I believe that they should be highlighted in some way.

@FrancescoSer FrancescoSer force-pushed the 54Hprerelease_docedits branch 4 times, most recently from 6bd0a84 to 1855d1e Compare August 28, 2024 15:50
@FrancescoSer
Copy link
Contributor Author

@hubertmis @divipillai Implemented most of your suggestions, and added additional sections in the architecture_pm document. While I'll implement the remaining suggestions, please feel free to rereview that document.

Copy link
Contributor

@annwoj annwoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some general suggestions

The application-facing APIs expose only the domain that directly clocks the component used by the application.
The management of the clocks on which this domain depends is handled internally by the clock driver associated with this domain.

For example, a firmware module might request better timing accuracy for a fast UART instance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For example, a firmware module might request better timing accuracy for a fast UART instance.
For example, a firmware module might request better timing accuracy for a high-speed UART instance.

tbc - would it be a correct wording here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hubertmis Could you check this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. In IPS I can find a term "Fast clock domain", but nothing directly about peripherals. The "fast UART" is the one in the "fast clock domain".


You can install the |NCS| v2.7.0 and its toolchain by using Toolchain Manager.
You can install the |NCS| v2.7.99-cs1 and its toolchain by using Toolchain Manager.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jangalda-nsc , the v2.7.99-cs1 is published?

Copy link
Contributor

@bjarki-andreasen bjarki-andreasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :) I only have two minor nits

@FrancescoSer FrancescoSer force-pushed the 54Hprerelease_docedits branch 4 times, most recently from e7e68d8 to 94b9e3d Compare August 29, 2024 08:15
Added firmware bundle compatibility table.
Updated nRF54H20 GS guide.
Added initial power management documentation.
Added initial clock control documentation.
Migration notes for |NCS| v2.7.99-cs1 and the nRF54H20 DK.

Signed-off-by: Francesco Domenico Servidio <francesco.servidio@nordicsemi.no>
@@ -214,17 +214,17 @@ To prepare the nRF54H20 DK for first use, you must manually program the values o

#. Move the BICR HEX file to a folder of your choice, then program the BICR by running nRF Util from that folder using the following command::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think that this step is required. This command can be executed from Downloads directory.
Additionally - Can we program BICR after switching to ROT LCS?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, BICR can be programmed at LCS ROT.


nrfutil install device=2.4.0 --force
nrfutil install device=2.4.6 --force
Copy link
Contributor

@nordic-piks nordic-piks Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did those steps at windows and got:

Downloads\nrfutil>nrfutil.exe  --version
nrfutil 7.6.0 (92ce3a0 2023-08-15)
commit-hash: 92ce3a0c1cc7e203326d85919d826009510dc631
commit-date: 2023-08-15
host: x86_64-pc-windows-msvc
build-timestamp: 2023-08-23T08:25:25.3155777Z
classification: nrf-external


Downloads\nrfutil>nrfutil self-upgrade
Error: Could not update package registry

Caused by:
    0: failed to fetch `https://github.com/nordicsemiconductor/nrfutil-package-index`
    1: network failure seems to have happened
       if a proxy or similar is necessary, setting the environment variable `NRFUTIL_NET_GIT_FETCH_WITH_CLI` to `true` may help here

    2: failed to set hostkey preference: The requested method(s) are not currently supported; class=Ssh (23)
    
   Downloads\nrfutil>nrfutil install device=2.4.6 --force
Error: Could not update package registry

Caused by:
    0: failed to fetch `https://github.com/nordicsemiconductor/nrfutil-package-index`
    1: network failure seems to have happened
       if a proxy or similar is necessary, setting the environment variable `NRFUTIL_NET_GIT_FETCH_WITH_CLI` to `true` may help here

    2: failed to set hostkey preference: The requested method(s) are not currently supported; class=Ssh (23)

Can someone confirm?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works at linux (WSL)

@gmarull gmarull merged commit 32b91a8 into nrfconnect:main Aug 29, 2024
13 checks passed
The application-facing APIs expose only the domain that directly clocks the component used by the application.
The management of the clocks on which this domain depends is handled internally by the clock driver associated with this domain.

For example, a firmware module might request better timing accuracy for a fast UART instance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. In IPS I can find a term "Fast clock domain", but nothing directly about peripherals. The "fast UART" is the one in the "fast clock domain".

*Local Suspend to RAM* is a sleep state that balances between power consumption and wake-up latency.

This state is available only for DVFS-capable domains.
Other domains, such as Radio, cannot retain the CPU and local peripherals in the *System ON (All) Idle* state.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like typo.

Suggested change
Other domains, such as Radio, cannot retain the CPU and local peripherals in the *System ON (All) Idle* state.
Other domains, such as Radio, can retain the CPU and local peripherals in hardware flip-flops in the *System ON (All) Idle* state.


#. Move the BICR HEX file to a folder of your choice, then program the BICR by running nRF Util from that folder using the following command::

nrfutil device program --options chip_erase_mode=ERASE_NONE --firmware <path_to_bicr.hex> --core Secure --serial-number <serialnumber>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--core Application
@FrancescoSer That needs to be updated too.
With Secure and device already provisioned (LCS ROT), it will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.