-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Documentation edits for 2.7.99-cs1 release #17015
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 8f816f4e70588b67d28891077a5681f223c31829 more detailssdk-nrf:
Github labels
List of changed files detected by CI (10)
Outputs:ToolchainVersion: Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped
Disable integration tests
Note: This message is automatically posted and updated by the CI |
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
408d986
to
d073dcc
Compare
d073dcc
to
d0a205e
Compare
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_clockman.rst
Outdated
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_clockman.rst
Outdated
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_clockman.rst
Outdated
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_clockman.rst
Outdated
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_clockman.rst
Outdated
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_clockman.rst
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_clockman.rst
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_pm.rst
Outdated
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_pm.rst
Outdated
Show resolved
Hide resolved
d0a205e
to
0838bb1
Compare
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture.rst
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_clockman.rst
Outdated
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_clockman.rst
Outdated
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_clockman.rst
Outdated
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_clockman.rst
Outdated
Show resolved
Hide resolved
Active | ||
====== | ||
|
||
*Active* is the power state in which the CPU is actively processing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the power states be made italic. I haven't see these mentioned as Italic in other docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not highlighting long power states name like "Local suspend to Ram" might render sentences containing these quite difficult to read. They don't have to be necessarily in italics, but I believe that they should be highlighted in some way.
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_pm.rst
Outdated
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_pm.rst
Outdated
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_pm.rst
Outdated
Show resolved
Hide resolved
6bd0a84
to
1855d1e
Compare
@hubertmis @divipillai Implemented most of your suggestions, and added additional sections in the architecture_pm document. While I'll implement the remaining suggestions, please feel free to rereview that document. |
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_pm.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some general suggestions
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_clockman.rst
Outdated
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_clockman.rst
Outdated
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_clockman.rst
Outdated
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_clockman.rst
Outdated
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_clockman.rst
Outdated
Show resolved
Hide resolved
The application-facing APIs expose only the domain that directly clocks the component used by the application. | ||
The management of the clocks on which this domain depends is handled internally by the clock driver associated with this domain. | ||
|
||
For example, a firmware module might request better timing accuracy for a fast UART instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example, a firmware module might request better timing accuracy for a fast UART instance. | |
For example, a firmware module might request better timing accuracy for a high-speed UART instance. |
tbc - would it be a correct wording here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hubertmis Could you check this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure. In IPS I can find a term "Fast clock domain", but nothing directly about peripherals. The "fast UART" is the one in the "fast clock domain".
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_clockman.rst
Outdated
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_clockman.rst
Outdated
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_clockman.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/migration/migration_guide_nRF54H20_cs_to_2_7_99-cs1.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/migration/migration_guide_nRF54H20_cs_to_2_7_99-cs1.rst
Outdated
Show resolved
Hide resolved
|
||
You can install the |NCS| v2.7.0 and its toolchain by using Toolchain Manager. | ||
You can install the |NCS| v2.7.99-cs1 and its toolchain by using Toolchain Manager. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jangalda-nsc , the v2.7.99-cs1 is published?
doc/nrf/releases_and_maturity/migration/migration_guide_nRF54H20_cs_to_2_7_99-cs1.rst
Outdated
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_gs.rst
Show resolved
Hide resolved
73786a0
to
b090335
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work :) I only have two minor nits
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_clockman.rst
Outdated
Show resolved
Hide resolved
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_architecture_clockman.rst
Outdated
Show resolved
Hide resolved
e7e68d8
to
94b9e3d
Compare
Added firmware bundle compatibility table. Updated nRF54H20 GS guide. Added initial power management documentation. Added initial clock control documentation. Migration notes for |NCS| v2.7.99-cs1 and the nRF54H20 DK. Signed-off-by: Francesco Domenico Servidio <francesco.servidio@nordicsemi.no>
94b9e3d
to
8f816f4
Compare
@@ -214,17 +214,17 @@ To prepare the nRF54H20 DK for first use, you must manually program the values o | |||
|
|||
#. Move the BICR HEX file to a folder of your choice, then program the BICR by running nRF Util from that folder using the following command:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think that this step is required. This command can be executed from Downloads
directory.
Additionally - Can we program BICR after switching to ROT LCS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, BICR can be programmed at LCS ROT.
|
||
nrfutil install device=2.4.0 --force | ||
nrfutil install device=2.4.6 --force |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just did those steps at windows and got:
Downloads\nrfutil>nrfutil.exe --version
nrfutil 7.6.0 (92ce3a0 2023-08-15)
commit-hash: 92ce3a0c1cc7e203326d85919d826009510dc631
commit-date: 2023-08-15
host: x86_64-pc-windows-msvc
build-timestamp: 2023-08-23T08:25:25.3155777Z
classification: nrf-external
Downloads\nrfutil>nrfutil self-upgrade
Error: Could not update package registry
Caused by:
0: failed to fetch `https://github.com/nordicsemiconductor/nrfutil-package-index`
1: network failure seems to have happened
if a proxy or similar is necessary, setting the environment variable `NRFUTIL_NET_GIT_FETCH_WITH_CLI` to `true` may help here
2: failed to set hostkey preference: The requested method(s) are not currently supported; class=Ssh (23)
Downloads\nrfutil>nrfutil install device=2.4.6 --force
Error: Could not update package registry
Caused by:
0: failed to fetch `https://github.com/nordicsemiconductor/nrfutil-package-index`
1: network failure seems to have happened
if a proxy or similar is necessary, setting the environment variable `NRFUTIL_NET_GIT_FETCH_WITH_CLI` to `true` may help here
2: failed to set hostkey preference: The requested method(s) are not currently supported; class=Ssh (23)
Can someone confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works at linux (WSL)
doc/nrf/app_dev/device_guides/working_with_nrf/nrf54h/ug_nrf54h20_gs.rst
Show resolved
Hide resolved
The application-facing APIs expose only the domain that directly clocks the component used by the application. | ||
The management of the clocks on which this domain depends is handled internally by the clock driver associated with this domain. | ||
|
||
For example, a firmware module might request better timing accuracy for a fast UART instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure. In IPS I can find a term "Fast clock domain", but nothing directly about peripherals. The "fast UART" is the one in the "fast clock domain".
*Local Suspend to RAM* is a sleep state that balances between power consumption and wake-up latency. | ||
|
||
This state is available only for DVFS-capable domains. | ||
Other domains, such as Radio, cannot retain the CPU and local peripherals in the *System ON (All) Idle* state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like typo.
Other domains, such as Radio, cannot retain the CPU and local peripherals in the *System ON (All) Idle* state. | |
Other domains, such as Radio, can retain the CPU and local peripherals in hardware flip-flops in the *System ON (All) Idle* state. |
|
||
#. Move the BICR HEX file to a folder of your choice, then program the BICR by running nRF Util from that folder using the following command:: | ||
|
||
nrfutil device program --options chip_erase_mode=ERASE_NONE --firmware <path_to_bicr.hex> --core Secure --serial-number <serialnumber> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--core Application
@FrancescoSer That needs to be updated too.
With Secure and device already provisioned (LCS ROT), it will fail.
Added firmware bundle compatibility table.
Updated nRF54H20 GS guide.
Added initial power management documentation.
Added initial clock control documentation