Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: matter: Enable Fprotect to secure factory data. #17054

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

ArekBalysNordic
Copy link
Contributor

Enabled FPROTECT in the Matter samples working on nRF54L15 to protect Matter Factory Data.

@ArekBalysNordic ArekBalysNordic requested a review from a team as a code owner August 28, 2024 09:47
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 28, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 28, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: 7d3b5a701c6fc6c240aead0341c12d002b2f1db8

more details

sdk-nrf:

PR head: 7d3b5a701c6fc6c240aead0341c12d002b2f1db8
merge base: 3d2536083c1cba5b2540a147b2c60704ff383b54
target head (main): 3d2536083c1cba5b2540a147b2c60704ff383b54> Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (19)
samples
│  ├── matter
│  │  ├── light_bulb
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15pdk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15pdk_nrf54l15_cpuapp_ns.conf
│  │  │  ├── sysbuild
│  │  │  │  ├── mcuboot
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54l15pdk_nrf54l15_cpuapp.conf
│  │  ├── light_switch
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15pdk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15pdk_nrf54l15_cpuapp_ns.conf
│  │  │  ├── sysbuild
│  │  │  │  ├── mcuboot
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54l15pdk_nrf54l15_cpuapp.conf
│  │  ├── lock
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15pdk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15pdk_nrf54l15_cpuapp_ns.conf
│  │  │  ├── sysbuild
│  │  │  │  ├── mcuboot
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54l15pdk_nrf54l15_cpuapp.conf
│  │  ├── template
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15pdk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15pdk_nrf54l15_cpuapp_ns.conf
│  │  │  ├── sysbuild
│  │  │  │  ├── mcuboot
│  │  │  │  │  ├── boards
│  │  │  │  │  │  ├── nrf54l15pdk_nrf54l15_cpuapp.conf
│  │  │  │  │  │  │ nrf54l15pdk_nrf54l15_cpuapp_internal.conf
│  │  ├── thermostat
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15pdk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15pdk_nrf54l15_cpuapp_ns.conf
│  │  │  ├── sysbuild
│  │  │  │  ├── mcuboot
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54l15pdk_nrf54l15_cpuapp.conf
│  │  ├── window_covering
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15pdk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15pdk_nrf54l15_cpuapp_ns.conf
│  │  │  ├── sysbuild
│  │  │  │  ├── mcuboot
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54l15pdk_nrf54l15_cpuapp.conf

Outputs:

Toolchain

Version: 5425d178a8
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:5425d178a8_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 111
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-chip
Disable integration tests
    • desktop52_verification
    • doc-internal
    • latest/ble/nrf/test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

@doublemis1
Copy link
Contributor

Template Internal configuration should also be affected by the change?

@ArekBalysNordic
Copy link
Contributor Author

Template Internal configuration should also be affected by the change?

Fortunately, the internal variant is covered by the nrf54l15pdk_nrf54l15_cpuapp.conf file. Only the separate pm_static file is required.

Enabled FPROTECT in the Matter samples working on nRF54L15
to protect Matter Factory Data.

Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
Copy link
Contributor

@kkasperczyk-no kkasperczyk-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should add release notes entry about adding fprotect support now, or when the full support will be available?

@ArekBalysNordic
Copy link
Contributor Author

Do you think we should add release notes entry about adding fprotect support now, or when the full support will be available?

As it was experimental support previously we didn't inform about it. Now it is the same as other samples so I guess we can skip this release note entry for the production support.

@ArekBalysNordic ArekBalysNordic removed DNM changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Aug 30, 2024
Copy link
Contributor

@doublemis1 doublemis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlubos rlubos merged commit 9fec64a into nrfconnect:main Sep 2, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants