Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suit: Changes in build system for extracting images to caches #17058

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

ahasztag
Copy link
Contributor

This commit introduces several changes which allow to severe firmware images from SUIT envelopes and extract them to raw cache files, which can then be flashed separately to the device.

@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Aug 28, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 28, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
suit-generator nrfconnect/suit-generator@97ef5bd nrfconnect/suit-generator@4372d27 (ncs) nrfconnect/suit-generator@97ef5bdd..4372d27e

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 28, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 7

Inputs:

Sources:

sdk-nrf: PR head: 4dc75a302169f3e4d9a3297ef28e55ea2ff38ebe
suit-generator: PR head: 4372d27e940798cb596d18d90affa9d62d9d2564

more details

sdk-nrf:

PR head: 4dc75a302169f3e4d9a3297ef28e55ea2ff38ebe
merge base: dc447947dc63bdae5b6ffbf17e4dadcd7989056e
target head (main): dc447947dc63bdae5b6ffbf17e4dadcd7989056e
Diff

suit-generator:

PR head: 4372d27e940798cb596d18d90affa9d62d9d2564
merge base: 97ef5bdd41716aa7fa21a0f0c149a66d1f91ab8d
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (19)
cmake
│  ├── sysbuild
│  │  ├── suit.cmake
│  │  │ suit_utilities.cmake
config
│  ├── suit
│  │  ├── templates
│  │  │  ├── nrf54h20
│  │  │  │  ├── default
│  │  │  │  │  ├── v1
│  │  │  │  │  │  ├── app_envelope.yaml.jinja2
│  │  │  │  │  │  │ rad_envelope.yaml.jinja2
│  │  │  │  ├── matter
│  │  │  │  │  ├── v1
│  │  │  │  │  │  ├── app_envelope.yaml.jinja2
│  │  │  │  │  │  │ rad_envelope.yaml.jinja2
modules
│  ├── lib
│  │  ├── suit-generator
│  │  │  ├── ncs
│  │  │  │  ├── Kconfig
│  │  │  │  ├── app_envelope_encrypted.yaml.jinja2
│  │  │  │  │ encrypt_script.py
│  │  │  ├── suit_generator
│  │  │  │  ├── args.py
│  │  │  │  ├── cli.py
│  │  │  │  ├── cmd_cache_create.py
│  │  │  │  ├── suit
│  │  │  │  │  ├── security.py
│  │  │  │  │  ├── types
│  │  │  │  │  │  │ keys.py
│  │  │  ├── tests
│  │  │  │  │ test_cmd_cache_create.py
samples
│  ├── suit
│  │  ├── smp_transfer
│  │  │  ├── sample.yaml
│  │  │  ├── suit
│  │  │  │  ├── nrf54h20
│  │  │  │  │  ├── app_envelope_extflash.yaml.jinja2
│  │  │  │  │  │ rad_envelope_extflash.yaml.jinja2
west.yml

Outputs:

Toolchain

Version: 9338b70c26
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:9338b70c26_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 1278
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-boot
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-sdk-find-my
    • ✅ test-sdk-mcuboot
    • ✅ test-sdk-dfu
    • ⚠️ test-sdk-dfu
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming commit message is meant to be sever and not severe?

endforeach()
list(APPEND CACHE_CREATE_ARGS "--output-file" "${SUIT_ROOT_DIRECTORY}dfu_cache_partition_${CACHE_PARTITION_NUM}.bin")

if (SUIT_DFU_CACHE_PARTITION_${CACHE_PARTITION_NUM}_EB_SIZE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uniform style, no space between if and bracket

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ahasztag ahasztag force-pushed the NCSDK-28881_dfu_cache_extract branch 3 times, most recently from b2422a2 to 7030217 Compare September 4, 2024 12:07
@NordicBuilder NordicBuilder removed the DNM label Sep 4, 2024
This commit introduces several changes which allow to severe
firmware images from SUIT envelopes and extract them to raw
cache files, which can then be flashed separately to the
device.

Signed-off-by: Artur Hadasz <artur.hadasz@nordicsemi.no>
This commit adds configurations to the smp_transfer sample, which
allow separating the firmware images from the root envelope and
sending them separately to the external flash.

The manifests templates was modified so that such update works.

Signed-off-by: Artur Hadasz <artur.hadasz@nordicsemi.no>
@ahasztag ahasztag force-pushed the NCSDK-28881_dfu_cache_extract branch from 151b259 to 4dc75a3 Compare September 5, 2024 08:32
@nordicjm nordicjm merged commit 8926100 into nrfconnect:main Sep 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-suit-generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants