Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: suit: Refactor of external flash configurations #17486

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

ahasztag
Copy link
Contributor

@ahasztag ahasztag commented Sep 25, 2024

The extflash file suffix did not allow to see what configuration
options are needed for enabling specific external flash configurations.

It also caused the need of many duplications and did not really simplify
things.

Another thing which this commit does is renaming the configurations
to emphasize the features added by each on of them.

test-sdk-nrf: sdk-nrf-pr-17486

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Sep 25, 2024
@ahasztag ahasztag changed the title samples: suit: Replaced extflash suffix with direct configuration samples: suit: Refactor of external flash configurations Sep 25, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 25, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: d4965d572c255f19c3b3f0491a3e842236c0e393

more details

sdk-nrf:

PR head: d4965d572c255f19c3b3f0491a3e842236c0e393
merge base: ea1346ae54f756f0a80f65cdcce58b06a6f99899
target head (main): e8d2e38f24ea200e3b52424355b80371340a39a0
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (6)
samples
│  ├── suit
│  │  ├── smp_transfer
│  │  │  ├── boards
│  │  │  │  │ nrf54h20dk_nrf54h20_cpuapp_extflash.overlay
│  │  │  ├── sample.yaml
│  │  │  ├── sysbuild.cmake
│  │  │  ├── sysbuild
│  │  │  │  ├── hci_ipc_extflash.conf
│  │  │  │  │ hci_ipc_extflash_template.conf
│  │  │  │ sysbuild_extflash_template.conf

Outputs:

Toolchain

Version: 87afe3f0d0
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:87afe3f0d0_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 111
  • ✅ Integration tests
    • ✅ test-sdk-dfu
    • ⚠️ test-sdk-dfu
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

The extflash file suffix did not allow to see what configuration
options are needed for enabling specific external flash configurations.

It also caused the need of many duplications and did not really simplify
things.

Another thing which this commit does is renaming the configurations
to emphasize the features added by each on of them.

Signed-off-by: Artur Hadasz <artur.hadasz@nordicsemi.no>
@ahasztag ahasztag requested a review from a team as a code owner September 27, 2024 06:47
@rlubos rlubos merged commit d10658e into nrfconnect:main Sep 27, 2024
13 checks passed
@ahasztag ahasztag deleted the smp_transfer_extflash_changes branch November 4, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants