Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: lib: nrf_cloud_fota: enable SMP FOTA #17489

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Conversation

jayteemo
Copy link
Contributor

Enable SMP FOTA type for MQTT-based FOTA.

IRIS-9480
IRIS-9482

@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Sep 25, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 25, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 16

Inputs:

Sources:

sdk-nrf: PR head: d4c25b107582fa83d734ee72242767bbcda20fd9

more details

sdk-nrf:

PR head: d4c25b107582fa83d734ee72242767bbcda20fd9
merge base: c6b8384162c180e1efdad4eb67fc0992df437fba
target head (main): 84492d6d9264745050a018d01f4f333b285864c1
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (21)
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
include
│  ├── net
│  │  ├── nrf_cloud.h
│  │  │ nrf_cloud_defs.h
subsys
│  ├── net
│  │  ├── lib
│  │  │  ├── nrf_cloud
│  │  │  │  ├── Kconfig
│  │  │  │  ├── Kconfig.nrf_cloud_alert
│  │  │  │  ├── Kconfig.nrf_cloud_fota
│  │  │  │  ├── Kconfig.nrf_cloud_location
│  │  │  │  ├── Kconfig.nrf_cloud_log
│  │  │  │  ├── Kconfig.nrf_cloud_pgps
│  │  │  │  ├── Kconfig.nrf_cloud_shadow_info
│  │  │  │  ├── include
│  │  │  │  │  ├── nrf_cloud_download.h
│  │  │  │  │  ├── nrf_cloud_fota.h
│  │  │  │  │  │ nrf_cloud_transport.h
│  │  │  │  ├── src
│  │  │  │  │  ├── nrf_cloud.c
│  │  │  │  │  ├── nrf_cloud_codec_internal.c
│  │  │  │  │  ├── nrf_cloud_download.c
│  │  │  │  │  ├── nrf_cloud_fota.c
│  │  │  │  │  ├── nrf_cloud_fota_common.c
│  │  │  │  │  ├── nrf_cloud_fota_poll.c
│  │  │  │  │  │ nrf_cloud_transport.c
tests
│  ├── subsys
│  │  ├── net
│  │  │  ├── lib
│  │  │  │  ├── nrf_cloud
│  │  │  │  │  ├── cloud
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ fakes.h

Outputs:

Toolchain

Version: 9583beca34
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:9583beca34_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 311
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-boot
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ✅ test-fw-nrfconnect-nrf-iot_positioning
    • ✅ test-sdk-mcuboot
    • ⚠️ test-fw-nrfconnect-fw-update
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@plskeggs
Copy link
Contributor

LGTM

@jayteemo jayteemo force-pushed the IRIS-9480 branch 2 times, most recently from 6b294a1 to bcbf349 Compare September 26, 2024 22:53
@jayteemo jayteemo marked this pull request as ready for review September 26, 2024 22:57
@jayteemo jayteemo requested review from a team as code owners September 26, 2024 22:57
@jayteemo jayteemo force-pushed the IRIS-9480 branch 3 times, most recently from dd0c81c to 17dfb50 Compare September 27, 2024 00:19
@jayteemo jayteemo force-pushed the IRIS-9480 branch 3 times, most recently from a203be6 to 6f85b13 Compare September 27, 2024 03:50
Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit.

subsys/net/lib/nrf_cloud/Kconfig Outdated Show resolved Hide resolved
subsys/net/lib/nrf_cloud/Kconfig Show resolved Hide resolved
Use CONFIG_NRF_CLOUD_FOTA_LOG_LEVEL instead of
CONFIG_NRF_CLOUD_LOG_LEVEL for logging in the
nrf_cloud_fota_common.c file.

Signed-off-by: Justin Morton <justin.morton@nordicsemi.no>
Enable SMP FOTA type for MQTT-based FOTA.

IRIS-9480
IRIS-9482

Signed-off-by: Justin Morton <justin.morton@nordicsemi.no>
Improve Kconfig menu display and navigation.

Signed-off-by: Justin Morton <justin.morton@nordicsemi.no>
Copy link
Contributor

@wiba-nordic wiba-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs is good.

@rlubos rlubos merged commit a049903 into nrfconnect:main Sep 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants