-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: lib: nrf_cloud: Log connection info from lib #17490
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 40b71236c24f1ec7eb941428a6c19c06bfe77b73 more detailssdk-nrf:
Github labels
List of changed files detected by CI (14)
Outputs:ToolchainVersion: 9583beca34 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with minor nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, no more errors
3a9d1ba
to
24398d0
Compare
2e9b6d6
to
9856626
Compare
Some nRF Cloud connection information is available regardless of whether the device has successfully connected, whereas other information is only available post-connection. Separate out the post-connection info into a new function, and call both at the appropriate times in the nrf_cloud_libraries. Remove previous requirement to call these functions from the application. Jira: IRIS-9653 Signed-off-by: Pete Skeggs <peter.skeggs@nordicsemi.no> Co-authored-by: Justin Morton <justin.morton@nordicsemi.no>
@nrfconnect/ncs-co-build-system Need ack here. |
Some nRF Cloud connection information is available regardless of whether the device has successfully connected, whereas other information is only available post-connection.
Separate out the post-connection info into a new function, and call both at the appropriate times in the nrf_cloud_libraries.
Remove previous requirement to call these functions from the application.
Jira: IRIS-9653