Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: lib: nrf_cloud: Log connection info from lib #17490

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

plskeggs
Copy link
Contributor

@plskeggs plskeggs commented Sep 25, 2024

Some nRF Cloud connection information is available regardless of whether the device has successfully connected, whereas other information is only available post-connection.

Separate out the post-connection info into a new function, and call both at the appropriate times in the nrf_cloud_libraries.

Remove previous requirement to call these functions from the application.

Jira: IRIS-9653

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Sep 25, 2024
@plskeggs plskeggs requested a review from a team September 25, 2024 21:51
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 25, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 17

Inputs:

Sources:

sdk-nrf: PR head: 40b71236c24f1ec7eb941428a6c19c06bfe77b73

more details

sdk-nrf:

PR head: 40b71236c24f1ec7eb941428a6c19c06bfe77b73
merge base: 5440a2589aa49b1123f79273b41946999e24d6c9
target head (main): 5440a2589aa49b1123f79273b41946999e24d6c9
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (14)
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
include
│  ├── net
│  │  │ nrf_cloud.h
samples
│  ├── cellular
│  │  ├── nrf_cloud_multi_service
│  │  │  ├── src
│  │  │  │  │ cloud_connection.c
│  │  ├── nrf_cloud_rest_cell_location
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── nrf_cloud_rest_device_message
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── nrf_cloud_rest_fota
│  │  │  ├── src
│  │  │  │  │ main.c
subsys
│  ├── net
│  │  ├── lib
│  │  │  ├── nrf_cloud
│  │  │  │  ├── Kconfig
│  │  │  │  ├── coap
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ nrf_cloud_coap_transport.c
│  │  │  │  ├── src
│  │  │  │  │  ├── nrf_cloud.c
│  │  │  │  │  ├── nrf_cloud_fsm.c
│  │  │  │  │  ├── nrf_cloud_info.c
│  │  │  │  │  │ nrf_cloud_rest.c
tests
│  ├── subsys
│  │  ├── net
│  │  │  ├── lib
│  │  │  │  ├── nrf_cloud
│  │  │  │  │  ├── cloud
│  │  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ fakes.h

Outputs:

Toolchain

Version: 9583beca34
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:9583beca34_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 311
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-boot
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ✅ test-fw-nrfconnect-nrf-iot_positioning
    • ✅ test-sdk-mcuboot
    • ⚠️ test-fw-nrfconnect-fw-update
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Sep 25, 2024
@plskeggs plskeggs marked this pull request as ready for review September 25, 2024 23:04
@plskeggs plskeggs requested review from a team as code owners September 25, 2024 23:04
subsys/net/lib/nrf_cloud/src/nrf_cloud_info.c Outdated Show resolved Hide resolved
include/net/nrf_cloud.h Outdated Show resolved Hide resolved
subsys/net/lib/nrf_cloud/src/nrf_cloud_info.c Show resolved Hide resolved
Copy link
Contributor

@peknis peknis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor nits.

include/net/nrf_cloud.h Outdated Show resolved Hide resolved
include/net/nrf_cloud.h Outdated Show resolved Hide resolved
Copy link
Contributor

@tony-le-24 tony-le-24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no more errors

@plskeggs plskeggs marked this pull request as ready for review September 26, 2024 22:03
@plskeggs plskeggs requested a review from a team as a code owner September 26, 2024 22:03
@plskeggs plskeggs changed the title net: lib: nrf_cloud: Separate cloud info by state net: lib: nrf_cloud: Log connection info from lib Sep 26, 2024
subsys/net/lib/nrf_cloud/Kconfig Outdated Show resolved Hide resolved
subsys/net/lib/nrf_cloud/src/nrf_cloud_info.c Outdated Show resolved Hide resolved
@plskeggs plskeggs force-pushed the IRIS-9653 branch 2 times, most recently from 3a9d1ba to 24398d0 Compare September 26, 2024 23:56
@plskeggs plskeggs force-pushed the IRIS-9653 branch 4 times, most recently from 2e9b6d6 to 9856626 Compare October 2, 2024 19:11
Some nRF Cloud connection information is available regardless
of whether the device has successfully connected, whereas
other information is only available post-connection.

Separate out the post-connection info into a new function, and
call both at the appropriate times in the nrf_cloud_libraries.

Remove previous requirement to call these functions from the
application.

Jira: IRIS-9653

Signed-off-by: Pete Skeggs <peter.skeggs@nordicsemi.no>
Co-authored-by: Justin Morton <justin.morton@nordicsemi.no>
@rlubos
Copy link
Contributor

rlubos commented Oct 3, 2024

@nrfconnect/ncs-co-build-system Need ack here.

@rlubos rlubos merged commit 547aaab into nrfconnect:main Oct 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants