Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: broadcast_config_tool: Verify lc3 header file #17497

Conversation

alexsven
Copy link
Contributor

  • Compare the header file of a LC3 file with the configuration of a stream.
  • Print a warning if there is a mismatch, but do not halt process
  • OCT-3120

- Compare the header file of a LC3 file with the configuration of
  a stream.
- Print a warning if there is a mismatch, but do not halt process
- OCT-3120

Signed-off-by: Alexander Svensen <alexander.svensen@nordicsemi.no>
@alexsven alexsven requested a review from a team as a code owner September 26, 2024 09:04
@alexsven alexsven requested review from koffes, rick1082 and gWacey and removed request for a team September 26, 2024 09:04
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Sep 26, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 26, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 2a14724803390ddca6211bd4f55ada30615bce2f

more details

sdk-nrf:

PR head: 2a14724803390ddca6211bd4f55ada30615bce2f
merge base: 719e59235b11dee0a36fe8e6022a88d352ed5da7
target head (main): 547aaab19c52cc03660d57943a963480a042e14f
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (6)
applications
│  ├── nrf5340_audio
│  │  ├── src
│  │  │  ├── modules
│  │  │  │  ├── lc3_file.c
│  │  │  │  ├── lc3_file.h
│  │  │  │  ├── lc3_streamer.c
│  │  │  │  │ lc3_streamer.h
samples
│  ├── bluetooth
│  │  ├── broadcast_config_tool
│  │  │  ├── Kconfig
│  │  │  ├── src
│  │  │  │  │ main.c

Outputs:

Toolchain

Version: 87afe3f0d0
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:87afe3f0d0_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 427
  • ✅ Integration tests
    • ✅ test-sdk-audio
    • ✅ test-fw-nrfconnect-ble_samples
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@alexsven alexsven requested a review from a team as a code owner September 26, 2024 11:18
@alexsven alexsven force-pushed the OCT-3120-verify-stream-configuration-against-selected-lc-3-file branch from f5a807b to 8861529 Compare September 30, 2024 13:41
@rlubos
Copy link
Contributor

rlubos commented Oct 3, 2024

@nrfconnect/ncs-co-build-system Need ack here.

Copy link
Contributor

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look ok, but noticed a minor nit.

samples/bluetooth/broadcast_config_tool/Kconfig Outdated Show resolved Hide resolved
- Add config for broadcast_config_tool with experimental
- OCT-3120

Signed-off-by: Alexander Svensen <alexander.svensen@nordicsemi.no>
@alexsven alexsven force-pushed the OCT-3120-verify-stream-configuration-against-selected-lc-3-file branch from 8861529 to 2a14724 Compare October 4, 2024 06:50
@rlubos rlubos merged commit 15c2b52 into nrfconnect:main Oct 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants