Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applications: nrf_desktop: Drop nRF54L PDK support #17588

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

MarekPieta
Copy link
Contributor

Change drops nRF54L PDK support.

Jira: NCSDK-29420

@MarekPieta MarekPieta added the DNM label Oct 2, 2024
@MarekPieta MarekPieta requested review from a team as code owners October 2, 2024 06:07
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 2, 2024
@MarekPieta
Copy link
Contributor Author

#17561 needs to go in first

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 2, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 491da03a037cc0e5351a43013599a54a5b013f06

more details

sdk-nrf:

PR head: 491da03a037cc0e5351a43013599a54a5b013f06
merge base: 6d04523a4177c0f0eda531603d31f1cd42b8fcc1
target head (main): 4a34c9083a88920d3298f26a0e3058454c1b510d
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (31)
applications
│  ├── nrf_desktop
│  │  ├── configuration
│  │  │  ├── nrf54l15pdk_nrf54l15_cpuapp
│  │  │  │  ├── app.overlay
│  │  │  │  ├── buttons_def.h
│  │  │  │  ├── buttons_sim_def.h
│  │  │  │  ├── click_detector_def.h
│  │  │  │  ├── hid_keyboard_leds_def.h
│  │  │  │  ├── hid_keyboard_leds_def_keyboard.h
│  │  │  │  ├── hid_keymap_def.h
│  │  │  │  ├── hid_keymap_def_keyboard.h
│  │  │  │  ├── images
│  │  │  │  │  ├── mcuboot
│  │  │  │  │  │  ├── app.overlay
│  │  │  │  │  │  ├── mcuboot_private.pem
│  │  │  │  │  │  ├── mcuboot_private_fast_pair.pem
│  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  ├── prj_fast_pair.conf
│  │  │  │  │  │  ├── prj_keyboard.conf
│  │  │  │  │  │  │ prj_release.conf
│  │  │  │  ├── led_state_def.h
│  │  │  │  ├── pm_static.yml
│  │  │  │  ├── pm_static_fast_pair.yml
│  │  │  │  ├── pm_static_keyboard.yml
│  │  │  │  ├── pm_static_release.yml
│  │  │  │  ├── port_state_def.h
│  │  │  │  ├── prj.conf
│  │  │  │  ├── prj_fast_pair.conf
│  │  │  │  ├── prj_keyboard.conf
│  │  │  │  ├── prj_release.conf
│  │  │  │  ├── sysbuild.conf
│  │  │  │  ├── sysbuild_fast_pair.conf
│  │  │  │  ├── sysbuild_keyboard.conf
│  │  │  │  │ sysbuild_release.conf
│  │  │ sample.yaml
scripts
│  ├── hid_configurator
│  │  │ NrfHidManager.py

Outputs:

Toolchain

Version: 6c44240e03
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:6c44240e03_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 74
  • ✅ Integration tests
    • ✅ desktop52_verification
Disabled integration tests
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@greg-fer greg-fer removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 2, 2024
@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. and removed doc-required PR must not be merged without tech writer approval. labels Oct 3, 2024
@MarekPieta MarekPieta removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 3, 2024
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 7, 2024
@MarekPieta MarekPieta removed DNM changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 7, 2024
Copy link
Contributor

@kapi-no kapi-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for this first #17436 to minimize the usage of CI resources

Copy link
Contributor

@kapi-no kapi-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing NAK, @MarekPieta please rebase and fix conflict

Change drops nRF54L PDK support.

Jira: NCSDK-29420

Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
Change drops nRF54L PDK support.

Jira: NCSDK-29420

Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
@kapi-no kapi-no self-requested a review October 8, 2024 13:01
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 8, 2024
@MarekPieta MarekPieta removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 8, 2024
@nordicjm nordicjm merged commit 0b48922 into nrfconnect:main Oct 9, 2024
14 checks passed
@MarekPieta MarekPieta deleted the nrf_desktop_drop_nrf54l15pdk branch October 9, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants