tests: nrf_auraconfig: Create BSIM tester #18898
Open
+5,146
−2,800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use generic broadcast_sink sample from Zephyr as base - Add a struct to contain all values to compare - Store adv_name and broadcast_name - Parse BASEs and populate struct - Add shell interface for setting expected values - Create function for comparing dut with expected - Compare all values and print success or fail - Add BSIM related files - OCT-3162 tests: nrf_auraconfig: Integrate with BSIM - Create a tester main for the nrf_auraconfig sample - Parse arguments and send to correct device - Add log level to le_audio_tx to suppress warnings - OCT-3193
alexsven
requested review from
koffes,
rick1082 and
gWacey
and removed request for
a team
github-actions
bot
added
the
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 12c1e3983969e852700ba355ba041c830deb09be more detailssdk-nrf:
Github labels
List of changed files detected by CI (32)Outputs:ToolchainVersion: b44b7a08c9 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
koffes
requested changes
Nov 15, 2024
| config SW_CODEC_NONE | ||
| bool "None" | ||
| help | ||
| Choose this if no sw codec is needed. |
There was a problem hiding this comment.
Suggested change
| Choose this if no sw codec is needed. | |
| Choose this if no software (SW) codec is needed. |
| @@ -157,7 +157,7 @@ static int audio_sync_timer_init(void) | |||
| return -ENODEV; | |||
| } | |||
|
|
|||
| IRQ_CONNECT(RTC0_IRQn, IRQ_PRIO_LOWEST, nrfx_rtc_0_irq_handler, NULL, 0); | |||
| IRQ_CONNECT(RTC0_IRQn, IRQ_PRIO_LOWEST, nrfx_isr, nrfx_rtc_0_irq_handler, 0); | |||
There was a problem hiding this comment.
I would like an explanation of this change.
| {.use_case = PERSONAL_MULTI_LANGUAGE, .name = "Personal multi-language"}, | ||
| }; | ||
| /* Main function */ | ||
| int nrf_auraconfig(void); |
There was a problem hiding this comment.
consider
Suggested change
| int nrf_auraconfig(void); | |
| int nrf_auraconfig_main(void); |
What is the standard naming convention?
| @@ -0,0 +1,176 @@ | |||
| /* | |||
There was a problem hiding this comment.
This file looks like a clean copy-paste?
| return ret; | ||
| } | ||
|
|
||
| (void)nrf_auraconfig(); |
There was a problem hiding this comment.
I may see this later, but why is there no err check?
| #include "nac_test.h" | ||
|
|
||
| #define SEM_TIMEOUT K_SECONDS(60) | ||
| #define BROADCAST_ASSISTANT_TIMEOUT K_SECONDS(120) /* 2 minutes */ |
There was a problem hiding this comment.
Suggested change
| #define BROADCAST_ASSISTANT_TIMEOUT K_SECONDS(120) /* 2 minutes */ | |
| #define BROADCAST_ASSISTANT_TIMEOUT K_SECONDS(120) /* 2 minutes */ | |
| ``` Butter on lard as they say :) |
| CONFIG_BT_CTLR_ADV_ISO_STREAM_COUNT=2 | ||
|
|
||
| # Support two links as a central, or one link as a peripheral | ||
| CONFIG_BT_MAX_CONN=3 |
|
|
||
| # To present the audio at the right point in time, we need the controller and | ||
| # audio clock to be synchronized | ||
| CONFIG_MPSL_TRIGGER_IPC_TASK_ON_RTC_START=y |
| SCRIPT_NAME=$(basename "$0") | ||
|
|
||
| ${SCRIPT_DIR}/../nrf_auraconfig_simulation.sh ${SCRIPT_NAME} \ | ||
| "nac" "usecase" "0"\ |
| @@ -0,0 +1,1169 @@ | |||
| /* | |||
There was a problem hiding this comment.
This is the last file I will need to go through. Will publish the comments I have for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests: nrf_auraconfig: Integrate with BSIM