Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: wayland: update desktop app names #18911

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

doc: wayland: update desktop app names #18911

wants to merge 1 commit into from

Conversation

greg-fer
Copy link
Contributor

Updated nRF Connect for Desktop app names to match the application. Dropped nRF Connect from the name and added app after. Reasons in NCD-1066.

@greg-fer
doc: wayland: update desktop app names
029d5d0 
Updated nRF Connect for Desktop app names to match the application.
Dropped `nRF Connect` from the name and added `app` after.
Reasons in NCD-1066.

Signed-off-by: Grzegorz Ferenc <Grzegorz.Ferenc@nordicsemi.no>
@greg-fer greg-fer requested review from a team and FrancescoSer as code owners November 15, 2024 10:35
@greg-fer greg-fer requested review from umapraseeda and divipillai and removed request for a team November 15, 2024 10:35
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 15, 2024
@greg-fer greg-fer added CI-disable Disable CI for this PR doc only and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 15, 2024
@greg-fer greg-fer added this to the 2.9.0 milestone Nov 15, 2024
@NordicBuilder
Copy link
Contributor

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 1

Inputs:

Sources:

more details

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (0)

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests

Note: This message is automatically posted and updated by the CI

wiba-nordic
wiba-nordic approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@wiba-nordic wiba-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Picked one nit, but looks good to me.

applications/asset_tracker_v2/doc/asset_tracker_v2_description.rst
#. Connect to the kit with a terminal emulator (for example, `nRF Connect Serial Terminal`_).
You can also use the :guilabel:`Open Serial Terminal` option of the `Cellular Monitor`_ app to open the Serial Terminal.
Using the Cellular Monitor app in combination with the nRF Connect Serial Terminal shows how the modem responds to the different modem commands.
#. Connect to the kit with a terminal emulator (for example, `Serial Terminal app`_).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#. Connect to the kit with a terminal emulator (for example, `Serial Terminal app`_).
#. Connect to the kit with a terminal emulator (for example, the `Serial Terminal app`_).

peknis
peknis approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@peknis peknis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor nit.

samples/cellular/lte_ble_gateway/README.rst
@@ -131,7 +131,7 @@ Program the main controller as follows:
west build --board nrf9160dk@1.1.0/nrf9160/ns

#. Verify that the programming was successful.
To do so, use a terminal emulator, like nRF Connect Serial Terminal, to connect to the first serial port and check the output.
To do so, use a terminal emulator, like the Serial Terminal app, to connect to the first serial port and check the output.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To do so, use a terminal emulator, like the Serial Terminal app, to connect to the first serial port and check the output.
Use a terminal emulator, like the Serial Terminal app, to connect to the first serial port and check the output.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And link probably?

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

divipillai
divipillai reviewed Nov 15, 2024
View reviewed changes
applications/asset_tracker_v2/doc/asset_tracker_v2_description.rst
You can also use the :guilabel:`Open Serial Terminal` option of the `Cellular Monitor`_ app to open the Serial Terminal.
Using the Cellular Monitor app in combination with the nRF Connect Serial Terminal shows how the modem responds to the different modem commands.
#. Connect to the kit with a terminal emulator (for example, `Serial Terminal app`_).
You can also use the :guilabel:`Open Serial Terminal` option of the `Cellular Monitor app`_ app to open the Serial Terminal app.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can also use the :guilabel:`Open Serial Terminal` option of the `Cellular Monitor app`_ app to open the Serial Terminal app.
You can also use the :guilabel:`Open Serial Terminal` option of the `Cellular Monitor app`_ to open the Serial Terminal app.

samples/bluetooth/peripheral_uart/README.rst
@@ -26,7 +26,7 @@ The sample supports the following development kits:
* When used with :ref:`zephyr:nrf5340dk_nrf5340`, the sample might support the MCUboot bootloader with serial recovery of the networking core image.

The sample also requires using a compatible application for `Testing`_.
You can use the `nRF Connect Bluetooth Low Energy`_ or `nRF Connect for Mobile`_ applications (or other similar applications, such as `nRF Blinky`_ or `nRF Toolbox`_).
You can use the `Bluetooth Low Energy app`_ or the `nRF Connect for Mobile`_ mobile app (or other similar applications, such as `nRF Blinky`_ or `nRF Toolbox`_).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can use the `Bluetooth Low Energy app`_ or the `nRF Connect for Mobile`_ mobile app (or other similar applications, such as `nRF Blinky`_ or `nRF Toolbox`_).
You can use the `Bluetooth Low Energy app`_ or the `nRF Connect for Mobile`_ mobile app (or other similar applications, such as `nRF Blinky`_ or `nRF Toolbox`_).

should me avoid the mention of two mobile words here?

divipillai
divipillai reviewed Nov 15, 2024
View reviewed changes
samples/bluetooth/peripheral_uart/README.rst
@@ -321,7 +321,7 @@ Testing with Bluetooth Low Energy app
-------------------------------------

If you have an nRF52 Series DK with the Peripheral UART sample and either a dongle or second Nordic Semiconductor development kit that supports Bluetooth Low Energy, you can test the sample on your computer.
Use the `nRF Connect Bluetooth Low Energy`_ app in `nRF Connect for Desktop`_ for testing.
Use the `Bluetooth Low Energy app`_ in `nRF Connect for Desktop`_ for testing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line no: 328 would also require an update as "Bluetooth Low Energy app"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divipillai divipillai divipillai left review comments

@wiba-nordic wiba-nordic wiba-nordic approved these changes

@peknis peknis peknis approved these changes

@mia-ko mia-ko mia-ko approved these changes

@FrancescoSer FrancescoSer Awaiting requested review from FrancescoSer FrancescoSer is a code owner

@umapraseeda umapraseeda Awaiting requested review from umapraseeda umapraseeda is a code owner automatically assigned from nrfconnect/ncs-cia-doc

Assignees
No one assigned
Labels
CI-disable Disable CI for this PR doc only doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
7 participants
@greg-fer @NordicBuilder @umapraseeda @mia-ko @peknis @wiba-nordic @divipillai