Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applications: nrf_desktop: enable watchdog module for nRF54H20 DK #18914

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

applications: nrf_desktop: enable watchdog module for nRF54H20 DK #18914

wants to merge 1 commit into from
+9 −2

Conversation

kapi-no
Copy link
Contributor

@kapi-no kapi-no commented Nov 15, 2024

Enabled the Watchdog module in release configuration of the nRF Desktop application for the nRF54H20 DK target.

Ref: NCSDK-25090

@kapi-no
applications: nrf_desktop: enable watchdog module for nRF54H20 DK
7389e49 
Enabled the Watchdog module in release configuration of the nRF Desktop
application for the nRF54H20 DK target.

Ref: NCSDK-25090

Signed-off-by: Kamil Piszczek <Kamil.Piszczek@nordicsemi.no>
@kapi-no kapi-no requested review from a team as code owners November 15, 2024 12:00
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Nov 15, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 15, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: 7389e49616d521b7c73fd567722058fac5b23287

more details

sdk-nrf:

PR head: 7389e49616d521b7c73fd567722058fac5b23287
merge base: d34297a836f9a1c0cd3730a1529cc17a0966a7f5
target head (main): 0a168646151e03a58cb9090e35f37081fd135f0c
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3) 
applications
│  ├── nrf_desktop
│  │  ├── configuration
│  │  │  ├── nrf54h20dk_nrf54h20_cpuapp
│  │  │  │  ├── app.overlay
│  │  │  │  │ prj_release.conf
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst

Outputs:

Toolchain

Version: f51bdba1d9
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:f51bdba1d9_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 82
  • ✅ Integration tests
    • ✅ desktop52_verification
Disabled integration tests
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

MarekPieta
MarekPieta approved these changes Nov 15, 2024
View reviewed changes
applications/nrf_desktop/configuration/nrf54h20dk_nrf54h20_cpuapp/app.overlay
@@ -4,6 +4,11 @@
* SPDX-License-Identifier: LicenseRef-Nordic-5-Clause
*/

/* For nRF54H, watchdog status is disabled by default. Needs to be enabled in DTS overlay. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we shouldn't introduce app_release.overlay for that purpose - watchdog is used only by the release configuration (similar note for nRF54L). We used to keep it in common DTS overlay, because some time ago build system used not to support DTS overlays per build type.

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
@@ -203,7 +203,7 @@ nRF5340 Audio
nRF Desktop
-----------

|no_changes_yet_note|
* Added support for the :ref:`nrf_desktop_watchdog` in the release configuration for the :ref:`zephyr:nrf54h20dk_nrf54h20`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added support -> Enabled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peknis peknis peknis approved these changes

@MarekPieta MarekPieta MarekPieta approved these changes

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kapi-no @NordicBuilder @MarekPieta @peknis