Skip to content

Commit

Permalink
GHA: fix warning on GHA
Browse files Browse the repository at this point in the history
fix workflow for building docker images

Signed-off-by: Robert Gałat <robert.galat@nordicsemi.no>
  • Loading branch information
RobertGalatNordic committed Sep 24, 2024
1 parent eccd3d4 commit 8a493a0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions .github/docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ RUN <<EOT
chmod +x /usr/local/bin/nrfutil
nrfutil install toolchain-manager
nrfutil install device
nrfutil install completion
EOT

RUN wget ${command_line_tools_url}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/on_docker_change.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,20 +30,20 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v4
- name: Log in to the Container registry
uses: docker/login-action@f054a8b539a109f9f41c372932f1ae047eff08c9
uses: docker/login-action@v3
with:
registry: ${{ env.REGISTRY }}
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Extract metadata (tags, labels) for Docker
id: meta
uses: docker/metadata-action@98669ae865ea3cffbcbaa878cf57c20bbf1c6c38
uses: docker/metadata-action@v5
with:
images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}

- name: Build and push Docker image
uses: docker/build-push-action@ad44023a93711e3deb337508980b4b5e9bcdc5dc
uses: docker/build-push-action@v5
with:
context: .
file: .github/docker/Dockerfile
Expand Down

0 comments on commit 8a493a0

Please sign in to comment.