[nrf fromtree] Samples: Bluetooth: Fix PAwR sample failed to set subevent data #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
reviewed
Mar 25, 2024
Comment on lines
301
to
302
| .interval = per_adv_params.interval_min, | ||
| .window = per_adv_params.interval_min, |
There was a problem hiding this comment.
Scan interval and window are units of 0.625 ms, whereas the periodic advertising interval are in units of 1.25ms.
Is this intentional? If so, please add a comment to explain why we are setting these to the half the value of the PA interval.
There was a problem hiding this comment.
thanks for pointing it out. Those values should be double.
There was a problem hiding this comment.
reused the macros for contiuous scanner. zephyrproject-rtos/zephyr#70044
ryanjh
force-pushed
the
periodic_adv_rsp_continuous_scan
branch
2 times, most recently
from
ba65bc1
to
791768f
Compare
ryanjh
changed the title
ryanjh
force-pushed
the
periodic_adv_rsp_continuous_scan
branch
2 times, most recently
from
c89f8d4
to
e6bd8ba
Compare
ryanjh
changed the title
NordicBuilder
requested review from
alwa-nordic,
carlescufi,
cvinayak,
jori-nordic,
kruithofa and
theob-pro
It is often desired to maximize the chances of receiving advertising when scanning. To achieve this, the scanner should be enabled all the time. Some controller implementations (like Nordic's SoftDevice Controller) handle scheduling differently when scan_window = scan_interval. Having a macro that defines this scanning configuration simplifies writing applications. Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no> (cherry picked from commit 7c2f26b)
…vent data Be respectful of PAwR subevents while scheduling scan activities. The radio will be swtiched from scan to PAwR when it is closed to the next subevent interval. Signed-off-by: Ryan Chu <ryan.chu@nordicsemi.no> (cherry picked from commit 2759a35)
ryanjh
force-pushed
the
periodic_adv_rsp_continuous_scan
branch
from
e6bd8ba
to
2d14cee
Compare
rugeGerritsen
approved these changes
Apr 2, 2024
hermabe
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be respectful of PAwR subevents while scheduling scan activities. The radio will be swtiched from scan to PAwR when it is closed to the next subevent interval.
Upstream PR: zephyrproject-rtos/zephyr#70678