Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vMix): support index (list, photo, virtual set) in vMix #358

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

ianshade
Copy link
Contributor

About the Contributor

This pull request is posted on behalf of TV 2 Norge

Type of Contribution

This is a:

Feature

Current Behavior

Index of inputs of types Photos, List and Virtual Set cannot be controlled by TSR.

New Behavior

Index of inputs of types:

  • Photos, List (Selects the item in the list)
  • Virtual Set (Zooms to selected preset using the current speed settings)

...can be controlled by the added index property of TimelineContentVMixInput, resulting in issuing the SelectIndex command.
The index starts from 1, which is not how indexes should work, but I'm following vMix's convention here.

Testing Instructions

  1. Add an input of one of the three mentioned types, with more than one item(preset)
  2. Create a mapping and a timeline object as shown in the 'supports index' test case
  3. Verify that the index changes when the timeline object starts

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@ianshade ianshade requested a review from a team as a code owner November 26, 2024 21:00
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.59%. Comparing base (3e5de55) to head (02db182).

Additional details and impacted files
@@              Coverage Diff              @@
##           release52     #358      +/-   ##
=============================================
+ Coverage      56.55%   56.59%   +0.04%     
=============================================
  Files            131      131              
  Lines          10274    10281       +7     
  Branches        2509     2571      +62     
=============================================
+ Hits            5810     5819       +9     
+ Misses          4462     4460       -2     
  Partials           2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nytamin nytamin merged commit ad41ae6 into nrkno:release52 Nov 27, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants