fix(core): Remove nameAndDirectoryFormat option from generators #28110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ndcunningham
commented
Sep 25, 2024
packages/devkit/src/generators/artifact-name-and-directory-utils.ts
Outdated
Show resolved
Hide resolved
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4468584. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
ndcunningham
force-pushed
the
fix/refactor-name-and-directory-format
branch
from
a9a6d4d
to
6d55a44
Compare
jaysoo
force-pushed
the
fix/refactor-name-and-directory-format
branch
from
34d1eb9
to
f5767b3
Compare
ndcunningham
force-pushed
the
fix/refactor-name-and-directory-format
branch
from
f5767b3
to
e21adb5
Compare
ndcunningham
force-pushed
the
fix/refactor-name-and-directory-format
branch
from
e21adb5
to
ca68a72
Compare
ndcunningham
force-pushed
the
fix/refactor-name-and-directory-format
branch
from
0112af8
to
cb7b954
Compare
jaysoo
approved these changes
Sep 26, 2024
ndcunningham
requested review from
a team,
Coly010,
FrozenPandaz,
vsavkin,
AgentEnder and
JamesHenry
as code owners
ndcunningham
force-pushed
the
fix/refactor-name-and-directory-format
branch
3 times, most recently
from
fe65e46
to
088086c
Compare
ndcunningham
force-pushed
the
fix/refactor-name-and-directory-format
branch
from
088086c
to
f737e61
Compare
ndcunningham
force-pushed
the
fix/refactor-name-and-directory-format
branch
from
f737e61
to
c43f162
Compare
jaysoo
force-pushed
the
fix/refactor-name-and-directory-format
branch
from
c43f162
to
0366daf
Compare
jaysoo
approved these changes
Sep 30, 2024
jaysoo
force-pushed
the
fix/refactor-name-and-directory-format
branch
from
0366daf
to
4b86afa
Compare
jaysoo
force-pushed
the
fix/refactor-name-and-directory-format
branch
from
4b86afa
to
4468584
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently, when we use generator's via the CLI passing the
namearg has more than one responsibility:This is not intuitive as if we use via Nx Console because it creates some ambiguity around the
--nameproperty which is normally described as only 2.Expected Behavior
What is expected is that the
nameproperty should only have the responsibility of determining the name of the generated module (Component, Directive etc...).The new property
pathreplaces thedirectoryproperty but fulfils the same purpose as determining where the module should be created.Related Issue(s)
Fixes #