Small store fixups #308
Merged
Small store fixups #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattF-NSIDC
reviewed
Sep 26, 2023
| @@ -533,7 +533,7 @@ def _get_granules( | |||
| provider = granules[0]["meta"]["provider-id"] | |||
| endpoint = self._own_s3_credentials(granules[0]["umm"]["RelatedUrls"]) | |||
| cloud_hosted = granules[0].cloud_hosted | |||
| access = "direc" if (cloud_hosted and self.running_in_aws) else "external" | |||
| access = "direct" if (cloud_hosted and self.running_in_aws) else "external" | |||
There was a problem hiding this comment.
Thinking out loud: I think it'd be really useful to add type safety here. We could type access as Enum or as a union of literal string types.
|
I got sidetracked last week and didn't have a chance to come back to this and my other problem that's described in #307 until now. I thought I might come across other items that may end up in this PR, but since I'm just getting re-started and I'm not certain of that, I want to make sure these small fixes get merged. |
jrbourbeau
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Generally this looks good to me. @betolink @MattF-NSIDC any additional thoughts?
|
🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of minor fixups that I noticed while looking at
earthaccess.store:accessvariable assignment (direc->direct)threadsarg to_open_urls_httpsin_open_urls, replacing hard-coded value of 8.