-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update pre-commit hooks #446
Conversation
fe04c8d
to
765b6ae
Compare
Our automatic pre-commit hooks update wants to bump prettier up to an alpha version. All the checks have passed, so it appears to be a safe change, but do we want to avoid alpha releases of hooks? |
I looked in to this some time ago, because it seems like something you should be able to turn off. But as of a few months ago, there was not a way to do this. I have this problem on many repositories. If you know of a way to avoid alpha bumps I need to know ;) |
What do we think is the way forward?
|
In this case, I'd say we remove https://github.com/pre-commit/mirrors-prettier because it has been archived. There aren't many alternatives for yaml formatting. A couple of others are also archived, such as this one: https://github.com/mmlb/yamlfmt Perhaps we go with this one: https://github.com/google/yamlfmt |
Maybe we should open a dedicated "deal with prettier & pre-commit" issue, and push a commit to this PR to use prettier 3.x and merge? Just to get it out of our backlog and focus our discussion. |
Sounds good |
Got the issue open, will have to come back to this PR later. |
765b6ae
to
53db07c
Compare
updates: - [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0) - [github.com/astral-sh/ruff-pre-commit: v0.1.6 → v0.4.3](astral-sh/ruff-pre-commit@v0.1.6...v0.4.3) - [github.com/pre-commit/mirrors-prettier: v3.1.0 → v4.0.0-alpha.8](pre-commit/mirrors-prettier@v3.1.0...v4.0.0-alpha.8)
53db07c
to
3ffbf19
Compare
updates:
📚 Documentation preview 📚: https://earthaccess--446.org.readthedocs.build/en/446/