Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pre-commit hooks #446

Merged
merged 1 commit into from
May 12, 2024
Merged

Conversation

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from fe04c8d to 765b6ae Compare April 1, 2024 23:06
@chuckwondo
Copy link
Collaborator

Our automatic pre-commit hooks update wants to bump prettier up to an alpha version. All the checks have passed, so it appears to be a safe change, but do we want to avoid alpha releases of hooks?

@mfisher87
Copy link
Collaborator

I looked in to this some time ago, because it seems like something you should be able to turn off. But as of a few months ago, there was not a way to do this. I have this problem on many repositories. If you know of a way to avoid alpha bumps I need to know ;)

@mfisher87 mfisher87 added the help wanted Extra attention is needed label Apr 19, 2024
@mfisher87
Copy link
Collaborator

What do we think is the way forward?

  • Turn off auto-updates
  • Edit the auto-update PRs before merging to remove alpha bumps
  • Use alpha prettier
  • ???

@chuckwondo
Copy link
Collaborator

What do we think is the way forward?

  • Turn off auto-updates
  • Edit the auto-update PRs before merging to remove alpha bumps
  • Use alpha prettier
  • ???

In this case, I'd say we remove https://github.com/pre-commit/mirrors-prettier because it has been archived.

There aren't many alternatives for yaml formatting. A couple of others are also archived, such as this one: https://github.com/mmlb/yamlfmt

Perhaps we go with this one: https://github.com/google/yamlfmt

@mfisher87
Copy link
Collaborator

Maybe we should open a dedicated "deal with prettier & pre-commit" issue, and push a commit to this PR to use prettier 3.x and merge? Just to get it out of our backlog and focus our discussion.

@chuckwondo
Copy link
Collaborator

Maybe we should open a dedicated "deal with prettier & pre-commit" issue, and push a commit to this PR to use prettier 3.x and merge? Just to get it out of our backlog and focus our discussion.

Sounds good

@mfisher87
Copy link
Collaborator

Got the issue open, will have to come back to this PR later.

#555

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 765b6ae to 53db07c Compare May 6, 2024 22:57
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0)
- [github.com/astral-sh/ruff-pre-commit: v0.1.6 → v0.4.3](astral-sh/ruff-pre-commit@v0.1.6...v0.4.3)
- [github.com/pre-commit/mirrors-prettier: v3.1.0 → v4.0.0-alpha.8](pre-commit/mirrors-prettier@v3.1.0...v4.0.0-alpha.8)
@chuckwondo chuckwondo force-pushed the pre-commit-ci-update-config branch from 53db07c to 3ffbf19 Compare May 12, 2024 14:47
@chuckwondo chuckwondo merged commit a1c5435 into main May 12, 2024
17 checks passed
@mfisher87 mfisher87 deleted the pre-commit-ci-update-config branch May 12, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants