Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: fix fetchLatestMissingBlockIndex and uploadIndexFiles in upload-bin command #3684

Merged
merged 3 commits into from
Nov 15, 2024
Merged

cli: fix fetchLatestMissingBlockIndex and uploadIndexFiles in upload-bin command #3684

merged 3 commits into from
Nov 15, 2024
+7 −7

Conversation

AliceInHunterland
Copy link
Contributor

@AliceInHunterland AliceInHunterland commented Nov 15, 2024 •
edited
Loading

Close #3667
Close #3669

@codecov Codecov
Copy link

codecov bot commented Nov 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.02%. Comparing base (c2b4d32) to head (375b095).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
cli/util/upload_bin.go 0.00% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3684      +/-   ##
==========================================
- Coverage   83.05%   83.02%   -0.04%     
==========================================
  Files         334      334              
  Lines       46599    46613      +14     
==========================================
- Hits        38704    38699       -5     
- Misses       6322     6338      +16     
- Partials     1573     1576       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AliceInHunterland AliceInHunterland changed the title cli: fix fetchLatestMissingBlockIndex in upload-bin command cli: fix fetchLatestMissingBlockIndex and uploadIndexFiles in upload-bin command Nov 15, 2024
AnnaShaleva
AnnaShaleva reviewed Nov 15, 2024
View reviewed changes
cli/util/upload_bin.go Outdated Show resolved Hide resolved
AnnaShaleva
AnnaShaleva reviewed Nov 15, 2024
View reviewed changes
cli/util/upload_bin.go Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
@AliceInHunterland
cli: fix fetchLatestMissingBlockIndex in upload-bin command
6e863e9 
Close #3667

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@AliceInHunterland
cli: fix stopping of uploadIndexFiles in upload-bin
380d112 
The expected count of index files should be counted based on the already
uploaded object number.

Close #3669

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@AliceInHunterland
cli: add details to the logs in upload-bin
375b095 
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@AnnaShaleva AnnaShaleva merged commit b97d0b2 into master Nov 15, 2024
30 of 34 checks passed
@AnnaShaleva AnnaShaleva deleted the last-block branch November 15, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaShaleva AnnaShaleva AnnaShaleva approved these changes

@roman-khimov roman-khimov Awaiting requested review from roman-khimov roman-khimov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AliceInHunterland @AnnaShaleva