cli: fix skip-blocks-uploading mode
#3686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3686 +/- ##
==========================================
+ Coverage 83.04% 83.06% +0.02%
==========================================
Files 334 334
Lines 46613 46629 +16
==========================================
+ Hits 38708 38733 +25
+ Misses 6333 6317 -16
- Partials 1572 1579 +7 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
reviewed
Nov 15, 2024
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
If uploadBlocks succeeded uploadIndexFiles should work based on the currentBlockHeight. Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland
force-pushed
the
fix-mode
branch
from
a13079a
to
5f6284d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If uploadBlocks succeeded uploadIndexFiles should work based on the current block height.