morph: drop inactive client mode, fix #2797

Reconnect indefinitely. After the initial probe this should be the behavior
for client, we can not work without blockchain data so we must wait for it as
long as needed, not entering any "inactive" state where the node pretends to
be alive, but can't do anything.

This makes client context (including everything belonging to it) an atomically
updated thing, regular calls fetch it when needed and can break if there are no
current connection. Meanwhile notification processing thread can reconnect when
needed and restore functionality.

Signed-off-by: Roman Khimov <roman@nspcc.ru>

CHANGELOG.md

@@ -22,6 +22,7 @@ attribute, which is used for container domain name in NNS contracts (#2954)
 - Structure table in the SN-configuration document (#2974)
 - False negative connection to NeoFS chain in multi-endpoint setup with at least one live node (#2986)
 - Overriding the default container and object attributes only with the appropriate flags (#2985)
+- RPC client reconnection failures leading to complete SN failure (#2797)
 
 ### Changed
 - `ObjectService`'s `Put` RPC handler caches up to 10K lists of per-object sorted container nodes (#2901)

cmd/neofs-node/config.go

@@ -668,9 +668,6 @@ func initBasics(c *cfg, key *keys.PrivateKey, stateStorage *state.PersistentStor
 				c.internalErr <- fmt.Errorf("restarting after morph connection was lost: %w", err)
 			}
 		}),
-		client.WithConnLostCallback(func() {
-			c.internalErr <- errors.New("morph connection has been lost")
-		}),
 		client.WithMinRequiredBlockHeight(fromSideChainBlock),
 	)
 	if err != nil {

pkg/innerring/innerring.go

@@ -1077,9 +1077,6 @@ func (s *Server) createClient(ctx context.Context, p chainParams, errChan chan<-
 				errChan <- fmt.Errorf("internal services' restart after RPC reconnection to the %s: %w", p.name, err)
 			}
 		}),
-		client.WithConnLostCallback(func() {
-			errChan <- fmt.Errorf("%s chain connection has been lost", p.name)
-		}),
 		client.WithMinRequiredBlockHeight(p.from),
 	}
 	if p.withAutoSidechainScope {