fix/GETRANGEHASH to a node without an object (#2557)

Closes #2541.

CHANGELOG.md

@@ -5,6 +5,7 @@ Changelog for NeoFS Node
 
 ### Fixed
 - `neofs-cli netmap netinfo` documentation (#2555)
+- `GETRANGEHASH` to a node without an object produced `GETRANGE` or `GET` requests (#2541)
 
 ### Changed
 - FSTree storage now uses more efficient and safe temporary files under Linux (#2566)

pkg/services/object/get/exec.go

@@ -356,8 +356,15 @@ func (exec execCtx) isForwardingEnabled() bool {
 	return exec.prm.forwarder != nil
 }
 
+// isRangeForwardingEnabled returns true if common execution
+// parameters has GETRANGEHASH request forwarding closure set.
+func (exec execCtx) isRangeForwardingEnabled() bool {
+	return exec.prm.rangeForwarder != nil
+}
+
 // disableForwarding removes request forwarding closure from common
 // parameters, so it won't be inherited in new execution contexts.
 func (exec *execCtx) disableForwarding() {
 	exec.prm.SetRequestForwarder(nil)
+	exec.prm.SetRangeRequestForwarder(nil)
 }

pkg/services/object/get/get.go

@@ -46,6 +46,13 @@ func (s *Service) GetRangeHash(ctx context.Context, prm RangeHashPrm) (*RangeHas
 			return nil, err
 		}
 
+		if rngPrm.forwardedRangeHashResponse != nil {
+			// forwarder request case; no need to collect the other
+			// parts, the whole response has already been received
+			hashes = rngPrm.forwardedRangeHashResponse
+			break
+		}
+
 		hashes = append(hashes, h.Sum(nil))
 	}
 

pkg/services/object/get/prm.go

@@ -1,6 +1,7 @@
 package getsvc
 
 import (
+	"context"
 	"crypto/ecdsa"
 	"errors"
 	"hash"
@@ -21,6 +22,8 @@ type RangePrm struct {
 	commonPrm
 
 	rng *object.Range
+
+	forwardedRangeHashResponse [][]byte
 }
 
 var (
@@ -58,7 +61,8 @@ type RangeHashPrm struct {
 	salt []byte
 }
 
-type RequestForwarder func(coreclient.NodeInfo, coreclient.MultiAddressClient) (*object.Object, error)
+type RequestForwarder func(context.Context, coreclient.NodeInfo, coreclient.MultiAddressClient) (*object.Object, error)
+type RangeRequestForwarder func(context.Context, coreclient.NodeInfo, coreclient.MultiAddressClient) ([][]byte, error)
 
 // HeadPrm groups parameters of Head service call.
 type HeadPrm struct {
@@ -74,7 +78,8 @@ type commonPrm struct {
 
 	raw bool
 
-	forwarder RequestForwarder
+	forwarder      RequestForwarder
+	rangeForwarder RangeRequestForwarder
 
 	// signerKey is a cached key that should be used for spawned
 	// requests (if any), could be nil if incoming request handling
@@ -141,6 +146,10 @@ func (p *commonPrm) SetRequestForwarder(f RequestForwarder) {
 	p.forwarder = f
 }
 
+func (p *commonPrm) SetRangeRequestForwarder(f RangeRequestForwarder) {
+	p.rangeForwarder = f
+}
+
 // WithAddress sets object address to be read.
 func (p *commonPrm) WithAddress(addr oid.Address) {
 	p.addr = addr

pkg/services/object/get/remote.go

@@ -35,7 +35,9 @@ func (exec *execCtx) processNode(info client.NodeInfo) bool {
 
 		// both object and err are nil only if the original
 		// request was forwarded to another node and the object
-		// has already been streamed to the requesting party
+		// has already been streamed to the requesting party,
+		// or it is a GETRANGEHASH forwarded request whose
+		// response is not an object
 		if obj != nil {
 			exec.collectedObject = obj
 			exec.writeCollectedObject()

pkg/services/object/get/util.go

@@ -88,7 +88,7 @@ func (c *clientCacheWrapper) get(info coreclient.NodeInfo) (getClient, error) {
 
 func (c *clientWrapper) getObject(exec *execCtx, info coreclient.NodeInfo) (*object.Object, error) {
 	if exec.isForwardingEnabled() {
-		return exec.prm.forwarder(info, c.client)
+		return exec.prm.forwarder(exec.ctx, info, c.client)
 	}
 
 	key, err := exec.key()
@@ -123,6 +123,11 @@ func (c *clientWrapper) getObject(exec *execCtx, info coreclient.NodeInfo) (*obj
 	// we don't specify payload writer because we accumulate
 	// the object locally (even huge).
 	if rng := exec.ctxRange(); rng != nil {
+		if exec.isRangeForwardingEnabled() {
+			exec.prm.forwardedRangeHashResponse, err = exec.prm.rangeForwarder(exec.ctx, info, c.client)
+			return nil, err
+		}
+
 		var prm internalclient.PayloadRangePrm
 
 		prm.SetContext(exec.context())

pkg/services/object/get/v2/util.go

@@ -2,6 +2,7 @@ package getsvc
 
 import (
 	"context"
+	"crypto/ecdsa"
 	"crypto/sha256"
 	"errors"
 	"fmt"
@@ -70,7 +71,7 @@ func (s *Service) toPrm(req *objectV2.GetRequest, stream objectSvc.GetObjectStre
 		var onceHeaderSending sync.Once
 		var globalProgress int
 
-		p.SetRequestForwarder(groupAddressRequestForwarder(func(addr network.Address, c client.MultiAddressClient, pubkey []byte) (*object.Object, error) {
+		p.SetRequestForwarder(groupAddressRequestForwarder(func(ctx context.Context, addr network.Address, c client.MultiAddressClient, pubkey []byte) (*object.Object, error) {
 			var err error
 
 			key, err := s.keyStorage.GetKey(nil)
@@ -102,7 +103,7 @@ func (s *Service) toPrm(req *objectV2.GetRequest, stream objectSvc.GetObjectStre
 			// open stream
 			var getStream *rpc.GetResponseReader
 			err = c.RawForAddress(addr, func(cli *rpcclient.Client) error {
-				getStream, err = rpc.GetObject(cli, req, rpcclient.WithContext(stream.Context()))
+				getStream, err = rpc.GetObject(cli, req, rpcclient.WithContext(ctx))
 				return err
 			})
 			if err != nil {
@@ -245,7 +246,7 @@ func (s *Service) toRangePrm(req *objectV2.GetRangeRequest, stream objectSvc.Get
 			return nil, err
 		}
 
-		p.SetRequestForwarder(groupAddressRequestForwarder(func(addr network.Address, c client.MultiAddressClient, pubkey []byte) (*object.Object, error) {
+		p.SetRequestForwarder(groupAddressRequestForwarder(func(ctx context.Context, addr network.Address, c client.MultiAddressClient, pubkey []byte) (*object.Object, error) {
 			var err error
 
 			// once compose and resign forwarding request
@@ -272,7 +273,7 @@ func (s *Service) toRangePrm(req *objectV2.GetRangeRequest, stream objectSvc.Get
 			// open stream
 			var rangeStream *rpc.ObjectRangeResponseReader
 			err = c.RawForAddress(addr, func(cli *rpcclient.Client) error {
-				rangeStream, err = rpc.GetObjectRange(cli, req, rpcclient.WithContext(stream.Context()))
+				rangeStream, err = rpc.GetObjectRange(cli, req, rpcclient.WithContext(ctx))
 				return err
 			})
 			if err != nil {
@@ -405,6 +406,62 @@ func (s *Service) toHashRangePrm(req *objectV2.GetRangeHashRequest) (*getsvc.Ran
 		})
 	}
 
+	if !commonPrm.LocalOnly() {
+		var onceResign sync.Once
+		var key *ecdsa.PrivateKey
+
+		key, err = s.keyStorage.GetKey(nil)
+		if err != nil {
+			return nil, err
+		}
+
+		p.SetRangeRequestForwarder(groupAddressRequestForwarder(func(ctx context.Context, addr network.Address, c client.MultiAddressClient, pubkey []byte) ([][]byte, error) {
+			meta := req.GetMetaHeader()
+
+			// once compose and resign forwarding request
+			onceResign.Do(func() {
+				// compose meta header of the local server
+				metaHdr := new(session.RequestMetaHeader)
+				metaHdr.SetTTL(meta.GetTTL() - 1)
+				// TODO: #1165 think how to set the other fields
+				metaHdr.SetOrigin(meta)
+				writeCurrentVersion(metaHdr)
+
+				req.SetMetaHeader(metaHdr)
+
+				err = signature.SignServiceMessage(key, req)
+			})
+			if err != nil {
+				return nil, err
+			}
+
+			var resp *objectV2.GetRangeHashResponse
+			err = c.RawForAddress(addr, func(cli *rpcclient.Client) error {
+				resp, err = rpc.HashObjectRange(cli, req, rpcclient.WithContext(ctx))
+				return err
+			})
+			if err != nil {
+				return nil, fmt.Errorf("GetRangeHash rpc failure: %w", err)
+			}
+
+			// verify response key
+			if err = internal.VerifyResponseKeyV2(pubkey, resp); err != nil {
+				return nil, err
+			}
+
+			// verify response structure
+			if err := signature.VerifyServiceMessage(resp); err != nil {
+				return nil, fmt.Errorf("could not verify %T: %w", resp, err)
+			}
+
+			if err = checkStatus(resp.GetMetaHeader().GetStatus()); err != nil {
+				return nil, err
+			}
+
+			return resp.GetBody().GetHashList(), nil
+		}))
+	}
+
 	return p, nil
 }
 
@@ -424,7 +481,7 @@ func (w *headResponseWriter) WriteHeader(hdr *object.Object) error {
 	return nil
 }
 
-func (s *Service) toHeadPrm(ctx context.Context, req *objectV2.HeadRequest, resp *objectV2.HeadResponse) (*getsvc.HeadPrm, error) {
+func (s *Service) toHeadPrm(_ context.Context, req *objectV2.HeadRequest, resp *objectV2.HeadResponse) (*getsvc.HeadPrm, error) {
 	body := req.GetBody()
 
 	addrV2 := body.GetAddress()
@@ -459,7 +516,7 @@ func (s *Service) toHeadPrm(ctx context.Context, req *objectV2.HeadRequest, resp
 	if !commonPrm.LocalOnly() {
 		var onceResign sync.Once
 
-		p.SetRequestForwarder(groupAddressRequestForwarder(func(addr network.Address, c client.MultiAddressClient, pubkey []byte) (*object.Object, error) {
+		p.SetRequestForwarder(groupAddressRequestForwarder(func(ctx context.Context, addr network.Address, c client.MultiAddressClient, pubkey []byte) (*object.Object, error) {
 			var err error
 
 			key, err := s.keyStorage.GetKey(nil)
@@ -654,11 +711,11 @@ func toShortObjectHeader(hdr *object.Object) objectV2.GetHeaderPart {
 	return sh
 }
 
-func groupAddressRequestForwarder(f func(network.Address, client.MultiAddressClient, []byte) (*object.Object, error)) getsvc.RequestForwarder {
-	return func(info client.NodeInfo, c client.MultiAddressClient) (*object.Object, error) {
+func groupAddressRequestForwarder[V any](f func(context.Context, network.Address, client.MultiAddressClient, []byte) (V, error)) func(context.Context, client.NodeInfo, client.MultiAddressClient) (V, error) {
+	return func(ctx context.Context, info client.NodeInfo, c client.MultiAddressClient) (V, error) {
 		var (
 			firstErr error
-			res      *object.Object
+			res      V
 
 			key = info.PublicKey()
 		)
@@ -676,7 +733,7 @@ func groupAddressRequestForwarder(f func(network.Address, client.MultiAddressCli
 				// would be nice to log otherwise
 			}()
 
-			res, err = f(addr, c, key)
+			res, err = f(ctx, addr, c, key)
 
 			return
 		})