Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/Add histograms for duration metrics #2473

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

carpawell
Copy link
Member

Deprecate prometheus.Counter analogs. Closes #2351.

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #2473 (1e60d56) into master (a7541ff) will not change coverage.
The diff coverage is n/a.

❗ Current head 1e60d56 differs from pull request most recent head a949ece. Consider uploading reports for the commit a949ece to get more accurate results

@@           Coverage Diff           @@
##           master    #2473   +/-   ##
=======================================
  Coverage   29.24%   29.24%           
=======================================
  Files         399      399           
  Lines       30368    30368           
=======================================
  Hits         8881     8881           
  Misses      20751    20751           
  Partials      736      736           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be OK otherwise.

CHANGELOG.md Show resolved Hide resolved
pkg/metrics/engine.go Outdated Show resolved Hide resolved
pkg/metrics/engine.go Outdated Show resolved Hide resolved
pkg/metrics/engine.go Outdated Show resolved Hide resolved
Deprecate `prometheus.Counter` analogs. Closes nspcc-dev#2351.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@roman-khimov roman-khimov merged commit f38069e into nspcc-dev:master Aug 9, 2023
6 of 8 checks passed
@carpawell carpawell deleted the feat/histogram-metrics branch August 9, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add histograms for request metrics
3 participants