Fix/object exist operation logs #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- there are no presents; - object address is always a good thing in error logs. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
No functional changes, but it prevents missing objects logs and stops execution earlier. Also, add a test that claims that inhuming object twice is error-free (exactly the case when strange logs used to appear before). Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
It is possible and safe after nspcc-dev/neofs-sdk-go#413. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2955 +/- ##
==========================================
- Coverage 23.53% 23.52% -0.01%
==========================================
Files 776 776
Lines 46606 46608 +2
==========================================
- Hits 10967 10966 -1
- Misses 34776 34778 +2
- Partials 863 864 +1 ☔ View full report in Codecov by Sentry. |
roman-khimov
approved these changes
Oct 1, 2024
cthulhu-rider
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.