node, ir: set default dial timeout to 1 minute #2963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End-rey
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2963 +/- ##
==========================================
- Coverage 23.47% 23.47% -0.01%
==========================================
Files 776 776
Lines 46558 46558
==========================================
- Hits 10930 10928 -2
- Misses 34763 34764 +1
- Partials 865 866 +1 ☔ View full report in Codecov by Sentry. |
roman-khimov
reviewed
Oct 7, 2024
End-rey
force-pushed
the
2891-change-connection-timeouts
branch
2 times, most recently
from
023b430
to
5b25511
Compare
carpawell
reviewed
Oct 8, 2024
There was a problem hiding this comment.
Stream timeout should be OK to raise
@roman-khimov the only problem I know about such timeouts raising is bad failover performance: once a node is down too many routines are waiting for too long before they think the node is dead.
Head/audit timeouts are also ok to me to be kept
Sure. Can be adjusted for fast networks. Mainnet/testnet are likely to be OK with 1m. |
End-rey
force-pushed
the
2891-change-connection-timeouts
branch
2 times, most recently
from
72f1149
to
9c757d4
Compare
carpawell
approved these changes
Oct 8, 2024
CHANGELOG.md
Outdated
| @@ -40,6 +41,11 @@ introduced in version 0.22.3 and support for binary keys was removed from | |||
| other components in 0.33.0 and 0.37.0. Please migrate to wallets (see 0.37.0 | |||
| notes) if you've not done it previously. | |||
|
|
|||
| Increace default timeout for dialing connections in node: `morph.dial_timeout`, | |||
There was a problem hiding this comment.
Suggested change
| Increace default timeout for dialing connections in node: `morph.dial_timeout`, | |
| Increase default timeout for dialing connections in node: `morph.dial_timeout`, |
Set default timeout for dialing connections in node: - `morph.dial_timeout` - `apiclient.dial_timout` - `apiclient.stream_timeout` and in inner ring: - `morph.dial_timout` - `morph.consensus.p2p.dial_timout` - `mainnet.dial_timout` to 1 minute. Update example configs and docs. Closes #2891. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
End-rey
force-pushed
the
2891-change-connection-timeouts
branch
from
9c757d4
to
ca8c9b5
Compare
roman-khimov
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2891.
Question about these timeouts:
apiclient.stream_timeoutpolicer.head_timeoutaudit.timeout.*Should I do the same for them?