cli: add a default range for object hash to cli help
#2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End-rey
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
cmd/neofs-cli/modules/object/hash.go
Outdated
| @@ -42,7 +42,7 @@ func initObjectHashCmd() { | |||
| flags.String(commonflags.OIDFlag, "", commonflags.OIDFlagUsage) | |||
| _ = objectHashCmd.MarkFlagRequired(commonflags.OIDFlag) | |||
|
|
|||
| flags.String("range", "", "Range to take hash from in the form offset1:length1,...") | |||
| flags.String("range", "", "Range to take hash from in the form offset1:length1,... (by default, gets a hash of the full object payload") | |||
There was a problem hiding this comment.
full object payload length if not specified?
End-rey
force-pushed
the
1693-docs-default-range-for-neofs-cli-object-hash
branch
from
6c287c8
to
4a753f0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2984 +/- ##
==========================================
- Coverage 22.90% 22.89% -0.01%
==========================================
Files 785 785
Lines 58747 58779 +32
==========================================
+ Hits 13455 13457 +2
- Misses 44415 44442 +27
- Partials 877 880 +3 ☔ View full report in Codecov by Sentry. |
carpawell
reviewed
Oct 28, 2024
cthulhu-rider
approved these changes
Oct 29, 2024
Also, print a verbose message if the default range length is used. Closes #1693. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
End-rey
force-pushed
the
1693-docs-default-range-for-neofs-cli-object-hash
branch
from
4a753f0
to
abcfe94
Compare
roman-khimov
approved these changes
Oct 29, 2024
carpawell
approved these changes
Oct 29, 2024
carpawell
deleted the
1693-docs-default-range-for-neofs-cli-object-hash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1693.
The
object hashcommand has logic whenlen(ranges) == 0, so I don't think it should be made obligatory.