cli: fix overriding of the Timestamp container attribute
#2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End-rey
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
carpawell
approved these changes
Oct 28, 2024
cthulhu-rider
requested changes
Oct 29, 2024
There was a problem hiding this comment.
there are also --name and --global-name attributty flags, they should be treated the same
also #1339 (comment) suggests to cover object attributes similarly within this issue, the current one is not enough to close the issue
End-rey
force-pushed
the
1339-undefined-behaviour-on-duplicated-container-attributes-when-using-neofs-cli
branch
from
a4f192d
to
25c2b07
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2985 +/- ##
==========================================
- Coverage 22.89% 22.87% -0.03%
==========================================
Files 785 785
Lines 58780 58806 +26
==========================================
- Hits 13460 13454 -6
- Misses 44441 44471 +30
- Partials 879 881 +2 ☔ View full report in Codecov by Sentry. |
End-rey
force-pushed
the
1339-undefined-behaviour-on-duplicated-container-attributes-when-using-neofs-cli
branch
from
25c2b07
to
43450f5
Compare
roman-khimov
approved these changes
Oct 29, 2024
End-rey
force-pushed
the
1339-undefined-behaviour-on-duplicated-container-attributes-when-using-neofs-cli
branch
from
43450f5
to
46ce633
Compare
cthulhu-rider
approved these changes
Oct 29, 2024
Add a check for the `Timestamp` and the `Name` container attributes, so there will be an error when you create a container with the `Timestamp` attribute without the `--disable-timestamp` flag or use the `Name` attribute, which is not equal to the `--name` flag. Add a check for the `Timestamp`, the `FileName` and the `__NEOFS__EXPIRATION_EPOCH` object attributes, so there will be an error when you put an object with the `Timestamp` attribute without the `--disable-timestamp` flag, with the `FileName` attribute without the `--disable-filename` flag or use the `__NEOFS__EXPIRATION_EPOCH` attribute, which is not equal to the expiration epoch from '--expire-at' or '--lifetime' flags. Move logic with expiration epoch attribute to `parseObjectAttrs` function. Closes #1339. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Check for the key and value of the container attributes for emptiness to prevent panic in the sdk. Check for the key and value of the object attributes for emptiness to prevent error from rpc. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
End-rey
force-pushed
the
1339-undefined-behaviour-on-duplicated-container-attributes-when-using-neofs-cli
branch
from
46ce633
to
455fccc
Compare
cthulhu-rider
deleted the
1339-undefined-behaviour-on-duplicated-container-attributes-when-using-neofs-cli
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1339.